[PM-37260] Profile service improvements#7924
Open
ike-kottlowski wants to merge 3 commits into
Open
Conversation
…ests for better readability and conceptualization.
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
| requestModel.UserAsymmetricKeys = TEST_ACCOUNT_KEYS; | ||
| var localFactory = new IdentityApplicationFactory(); | ||
|
|
||
| var user = await localFactory.RegisterNewIdentityFactoryUserAsync(requestModel); |
Comment on lines
+65
to
+70
| new FormUrlEncodedContent(new Dictionary<string, string> | ||
| { | ||
| { "grant_type", "refresh_token" }, | ||
| { "client_id", "web" }, | ||
| { "refresh_token", refreshToken }, | ||
| })); |
Comment on lines
+108
to
+113
| new FormUrlEncodedContent(new Dictionary<string, string> | ||
| { | ||
| { "grant_type", "refresh_token" }, | ||
| { "client_id", "web" }, | ||
| { "refresh_token", refreshToken }, | ||
| })); |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7924 +/- ##
==========================================
- Coverage 61.40% 61.37% -0.04%
==========================================
Files 2227 2237 +10
Lines 98345 98569 +224
Branches 8894 8911 +17
==========================================
+ Hits 60386 60492 +106
- Misses 35822 35941 +119
+ Partials 2137 2136 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
PM-37260
📔 Objective
Improve refresh token issuance though updates to the profile service.