Skip to content

[PM-25691] Create OrganizationUpdateCollectionManagementCommand#7682

Open
r-tome wants to merge 6 commits into
mainfrom
ac/pm-25691/create-updatecollectionmanagementsettings-command
Open

[PM-25691] Create OrganizationUpdateCollectionManagementCommand#7682
r-tome wants to merge 6 commits into
mainfrom
ac/pm-25691/create-updatecollectionmanagementsettings-command

Conversation

@r-tome
Copy link
Copy Markdown
Contributor

@r-tome r-tome commented May 20, 2026

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-25691

📔 Objective

Lift and shift the method UpdateCollectionManagementSettingsAsync from OrganizationService into a new command.

r-tome added 5 commits May 20, 2026 15:47
…terface for managing organization collection settings

* Add UpdateCollectionManagementSettingsCommand to handle updates to organization collection management settings.
* Create IUpdateCollectionManagementSettingsCommand interface to define the update method.
* Implement unit tests for UpdateCollectionManagementSettingsCommand to verify event logging and exception handling.
* Register IUpdateCollectionManagementSettingsCommand and its implementation, UpdateCollectionManagementSettingsCommand, in the service collection for managing organization collection settings.
…nagementCommand

* Added IOrganizationUpdateCollectionManagementCommand to the OrganizationsController for managing collection settings updates.
* Updated the constructor to inject the new command and modified the PutCollectionManagement method to utilize it.
* Adjusted unit tests to reflect the changes in the command used for updating collection management settings.
…eCollectionManagementSettingsAsync method

* Removed the UpdateCollectionManagementSettingsAsync method from IOrganizationService and its implementation in OrganizationService.
* Cleaned up unused usings related to collection management settings in both service files.
* Updated unit tests to reflect the removal of the collection management settings update functionality.
@r-tome r-tome added the ai-review Request a Claude code review label May 20, 2026
@github-actions
Copy link
Copy Markdown
Contributor

Claude Code is reviewing this pull request...

If this comment does not update with results, check the Actions log.

@r-tome r-tome changed the title Ac/pm 25691/create updatecollectionmanagementsettings command [PM-25691] Create OrganizationUpdateCollectionManagementCommand command May 20, 2026
@r-tome r-tome marked this pull request as ready for review May 20, 2026 15:04
@r-tome r-tome requested a review from a team as a code owner May 20, 2026 15:04
@r-tome r-tome requested a review from JaredScar May 20, 2026 15:04
@codecov
Copy link
Copy Markdown

codecov Bot commented May 20, 2026

Codecov Report

❌ Patch coverage is 94.11765% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 60.40%. Comparing base (24bd2b5) to head (24f9dba).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...s/OrganizationUpdateCollectionManagementCommand.cs 93.65% 0 Missing and 4 partials ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7682   +/-   ##
=======================================
  Coverage   60.40%   60.40%           
=======================================
  Files        2136     2137    +1     
  Lines       94548    94563   +15     
  Branches     8434     8434           
=======================================
+ Hits        57109    57124   +15     
  Misses      35436    35436           
  Partials     2003     2003           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@r-tome r-tome changed the title [PM-25691] Create OrganizationUpdateCollectionManagementCommand command [PM-25691] Create OrganizationUpdateCollectionManagementCommand May 21, 2026
@r-tome r-tome added needs-qa and removed ai-review Request a Claude code review labels May 21, 2026
@sonarqubecloud
Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants