[PM-36563] Send access event logs#7679
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7679 +/- ##
==========================================
+ Coverage 60.20% 60.43% +0.23%
==========================================
Files 2136 2136
Lines 94397 94596 +199
Branches 8409 8442 +33
==========================================
+ Hits 56827 57169 +342
+ Misses 35579 35421 -158
- Partials 1991 2006 +15 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
|
||
| if (send.UserId.HasValue | ||
| && send.Type == SendType.Text | ||
| && _featureService.IsEnabled(FeatureFlagKeys.SendEventLogging)) |
There was a problem hiding this comment.
🎨 Putting the feature flag check first in the if statement would be a minor benefit in terms of computation since if that flag is false, the other checks don't need to run at all! I see this in multiple places in the file and in other files, but definitely not blocking
There was a problem hiding this comment.
This should now be adjusted to prioritize the feature flag check ✅
|



🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-36563
📔 Objective
This PR adds EventTypes, control flow, and test coverage to log Send access events.
Companion
clientsPR: bitwarden/clients#20740