[PM-33889] Innovation Sprint Bitwarden Receive#7383
Draft
Conversation
* introduce new files for changes * add Receive entity * add migrations - EF do not add the table * correct migration files * remove comments from Receive.sql * remove MaxUploadCount * service with test coverage * address review comments * remove unused validation method - UserId not nullable * azure storage service initial impl * respond to review comments * update code comment ref Validated default * auth service with initial dapper repo * generate repo SPs and add test coverage * review suggested changes
* introduce new files for changes * add Receive entity * add migrations - EF do not add the table * correct migration files * remove comments from Receive.sql * remove MaxUploadCount * service with test coverage * address review comments * remove unused validation method - UserId not nullable * azure storage service initial impl * respond to review comments * update code comment ref Validated default * auth service with initial dapper repo * generate repo SPs and add test coverage * review suggested changes * fully register services implemented so far for MSSQL/Dapper
* introduce new files for changes * add Receive entity * add migrations - EF do not add the table * correct migration files * remove comments from Receive.sql * remove MaxUploadCount * service with test coverage * address review comments * remove unused validation method - UserId not nullable * azure storage service initial impl * respond to review comments * update code comment ref Validated default * auth service with initial dapper repo * generate repo SPs and add test coverage * review suggested changes * fully register services implemented so far for MSSQL/Dapper * initial req/resp models and empty controller * introduce ReceiveFileModel and connect to request response flow * ExpirationDate not nullable & add public key to file model --------- Co-authored-by: Alex Dragovich <46065570+itsadrago@users.noreply.github.com>
* Add create endpoint * Add endpoint for update and add name column * Fix tests
* [PM-34245] adding receive shared data endpoint * [PM-34245] fixing encoding issue * [PM-34245] shared receive response model obtains receive name properly
* endpoints, sync updates, and AI bug-fixes * fix merge conflict resolution
* [PM-34271] Receives file upload endpoint * [PM-34271] consistancy in placeholder naming for endpoint * [PM-34271] fixing injection issue * [PM-34271] removing length restriction from UserKeyWrappedPrivateKey
* initial implementation of file download * fix single file logic, support multi-upload * fix test and add EncapsulatedFileContentEncryptionKey to file upload flow * Remove Name from JSON data and update tests
* Add receive owner email to share response * Fix tests
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #7383 +/- ##
==========================================
+ Coverage 57.84% 62.41% +4.56%
==========================================
Files 2043 2088 +45
Lines 89879 91890 +2011
Branches 7989 8150 +161
==========================================
+ Hits 51992 57354 +5362
+ Misses 36029 32562 -3467
- Partials 1858 1974 +116 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
New Issues (121)Checkmarx found the following issues in this Pull Request
Fixed Issues (6)Great job! The following issues were fixed in this Pull Request
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-33889
📔 Objective
Bitwarden Receive