Conversation
…implementation along with associated tests
…ated implementations. Update PolicyServiceCollectionExtensions to eliminate deprecated methods. Adjust policy validator classes to remove IPolicyValidator dependency and streamline validation methods.
…m the policy validation framework.
…ync and side effect methods
…cyModel in validation and side effect methods, improving code clarity and reducing method complexity.
…DomainCommandTests to better reflect their functionality, enhancing clarity and consistency across the test suite.
r-tome
changed the title
Contributor
|
New Issues (122)Checkmarx found the following issues in this Pull Request
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #7364 +/- ##
==========================================
- Coverage 62.43% 58.28% -4.16%
==========================================
Files 2060 2059 -1
Lines 90974 90812 -162
Branches 8087 8073 -14
==========================================
- Hits 56803 52933 -3870
- Misses 32216 36007 +3791
+ Partials 1955 1872 -83 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…-savepolicycommand
r-tome
added
the
ai-review-vnext
Contributor
Bitwarden Claude Code ReviewOverall Assessment: APPROVE This PR completes the migration from the old policy validator pattern to the event-based policy validation pattern. It removes Code Review DetailsNo findings. The refactoring is mechanical and preserves existing behavior. The new |
…ed methods and simplifying the implementation. Update corresponding tests to reflect these changes.
…iles and update using statements for consistency.
enmande
previously approved these changes
Apr 1, 2026
Contributor
enmande
left a comment
enmande
left a comment
There was a problem hiding this comment.
Auth changes LGTM. Thank you!
…-savepolicycommand
|
jrmccannon
approved these changes
Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-29152
📔 Objective
Remove the old
SavePolicyCommand,ISavePolicyCommand,IPolicyValidator, andIPostSavePolicySideEffecttypes, then promote theVNextequivalents to their final names. This completes the migration to the event-based policy validation pattern.