Draft
Conversation
- I accidentally had the updated Program locally and that was why tests were working for me locally
Contributor
|
Great job! No new security vulnerabilities introduced in this pull request |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #7171 +/- ##
==========================================
+ Coverage 56.88% 61.50% +4.61%
==========================================
Files 2028 2032 +4
Lines 88826 89437 +611
Branches 7918 7972 +54
==========================================
+ Hits 50528 55005 +4477
+ Misses 36468 32496 -3972
- Partials 1830 1936 +106 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dereknance
force-pushed
the
pm-28727-dotnet-10
branch
from
ea9e897 to
9b95d79
Compare
|
# Conflicts: # global.json # util/Server/Program.cs
# Conflicts: # src/Core/Utilities/EncryptedStringAttribute.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
PM-28727
📔 Objective
This PR upgrades from .NET 8 to 10.
Prerequisites
Base64.IsValidenforces canonical padding.IHostBuilderstyle #6843WebHostBuilderis obsoleteSystem.Text.Json8.0.5 pin removed because package pruning emits NU1510MailKitupdated to fix vulnerability GHSA-g7hc-96xr-gvvxMicrosoft.AspNetCore.HttpOverrides.IPNetworkandKnownNetworkshave been marked as obsoleteNullReferenceExceptionin.Trim()calls. Added null-conditional operators in property setters inGlobalSettings.csIncidental changes
util/Server/Program.csand fixed a null check bug onwebRoot.