Skip to content

Conversation

@brant-livefront
Copy link
Contributor

📔 Objective

This PR is step one of our effort to move OrganizationConnection records and handling into our newer OrganizationIntegration architecture. This PR is just additive for now. It adds new repository methods to IOrganizationIntegrationRepository in anticipation of using these methods to handle what we're currently doing in the IOrganizationConnectionRepository

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@codecov
Copy link

codecov bot commented Dec 31, 2025

Codecov Report

❌ Patch coverage is 0% with 33 lines in your changes missing coverage. Please review.
✅ Project coverage is 58.80%. Comparing base (484a8e4) to head (2511591).

Files with missing lines Patch % Lines
...izationIntegrationReadByOrganizationIdTypeQuery.cs 0.00% 17 Missing ⚠️
.../Repositories/OrganizationIntegrationRepository.cs 0.00% 9 Missing ⚠️
.../Repositories/OrganizationIntegrationRepository.cs 0.00% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6788      +/-   ##
==========================================
- Coverage   58.83%   58.80%   -0.04%     
==========================================
  Files        1925     1926       +1     
  Lines       85355    85388      +33     
  Branches     7652     7652              
==========================================
- Hits        50217    50209       -8     
- Misses      33269    33311      +42     
+ Partials     1869     1868       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Details68b0e073-8a6f-4da1-8799-be88421a7ffb

Great job! No new security vulnerabilities introduced in this pull request

Copy link
Contributor

@mkincaid-bw mkincaid-bw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very minor formatting change

BEGIN
SET NOCOUNT ON

SELECT
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⛏️ Select statement should be indented 4 spaces

BEGIN
SET NOCOUNT ON

SELECT
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⛏️ Select statement should be indented 4 spaces

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants