[PM-25906] Add account switcher visibility tests #2168

LRNcardozoWDF · 2025-11-28T04:40:49Z

🎟️ Tracking

PM-25906

📔 Objective

Add tests for account switcher for iOS 26.

📸 Screenshots

⏰ Reminders before review

Contributor guidelines followed
All formatters and local linters executed and passed
Written new unit and / or integration tests where applicable
Protected functional changes with optionality (feature flags)
Used internationalization (i18n) for all UI strings
CI builds passed
Communicated to DevOps any deployment requirements
Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

👍 (:+1:) or similar for great changes
📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
❓ (:question:) for questions
🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
🎨 (:art:) for suggestions / improvements
❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
⛏ (:pick:) for minor or nitpick changes

…bility-tests

claude · 2025-11-28T04:42:07Z

Claude finished @LRNcardozoWDF's task in 1m 45s —— View job

Code Review Complete

Review posted by bitwarden-code-reviewer agent.

Summary: Comprehensive test coverage successfully added for iOS 26 account switcher visibility across 5 processor test files (49 new test cases). Tests follow proper patterns with iOS version gating and appropriate assertions.

github-actions · 2025-11-28T04:47:59Z

Checkmarx One – Scan Summary & Details – 0ace9533-b391-4a7d-b1f9-4641e9c8b294

Great job! No new security vulnerabilities introduced in this pull request

codecov · 2025-11-28T05:03:09Z

Codecov Report

❌ Patch coverage is 96.22642% with 40 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.57%. Comparing base (8ce5d66) to head (d95a520).
⚠️ Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
...I/Auth/VaultUnlock/VaultUnlockProcessorTests.swift	96.66%	14 Missing ⚠️
...Shared/UI/Auth/Landing/LandingProcessorTests.swift	96.61%	11 Missing ⚠️
...ault/Vault/VaultList/VaultListProcessorTests.swift	96.08%	9 Missing ⚠️
...AutofillList/VaultAutofillListProcessorTests.swift	92.30%	3 Missing ⚠️
...emSelection/VaultItemSelectionProcessorTests.swift	93.47%	3 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2168      +/-   ##
==========================================
+ Coverage   85.39%   85.57%   +0.18%     
==========================================
  Files        1731     1731              
  Lines      145718   146774    +1056     
==========================================
+ Hits       124433   125606    +1173     
+ Misses      21285    21168     -117

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

…bility-tests

claude · 2025-11-28T17:48:19Z

BitwardenShared/UI/Vault/Vault/VaultItemSelection/VaultItemSelectionProcessorTests.swift

+        }
+
+        subject.state.profileSwitcherState.isVisible = true
+        await subject.perform(.profileSwitcher(.accountPressed(ProfileSwitcherItem.fixture(userId: "1"))))


❌ Test setup ordering issue: Mock data is configured AFTER the action is performed (line 173), but these values should be set up BEFORE calling perform() on line 173.

The lines 174-181 should be moved above line 172. The test setup should follow this order:

Configure all mock dependencies and initial state

Perform the action being tested

Assert the results

This same issue appears in VaultAutofillListProcessorTests.swift:test_perform_profileSwitcher_accountPressed_iOS26() at line 201.

claude · 2025-11-28T17:48:24Z

BitwardenShared/UI/Vault/Vault/AutofillList/VaultAutofillListProcessorTests.swift

+        }
+
+        subject.state.profileSwitcherState.isVisible = true
+        await subject.perform(.profileSwitcher(.accountPressed(ProfileSwitcherItem.fixture(userId: "1"))))


❌ Test setup ordering issue: Same problem as in VaultItemSelectionProcessorTests.swift - mock data (lines 202-209) is configured AFTER the action is performed (line 201).

Move lines 202-209 above line 200 to ensure proper test setup order.

claude · 2025-11-28T18:00:19Z

BitwardenShared/UI/Vault/Vault/VaultItemSelection/VaultItemSelectionProcessorTests.swift

+        }
+
+        subject.state.profileSwitcherState.isVisible = true
+        await subject.perform(.profileSwitcher(.accountPressed(ProfileSwitcherItem.fixture(userId: "1"))))


❌ Critical: Test setup ordering violation

Mock data is configured AFTER the action is performed. Lines 173-180 must be moved above line 172.

Current (incorrect) order:

Set state (line 171) ✅

Perform action (line 172) ❌ Too early!

Configure mocks (lines 173-180) ❌ Too late!

Correct order should be:

Set state

Configure all mocks (activeAccount, altAccounts, vaultTimeout)

Then perform action

Assert results

This follows the standard Arrange-Act-Assert pattern (Testing.md:1033-1037). Currently the test runs with uninitialized mock values, producing incorrect results.

Suggested change

await subject.perform(.profileSwitcher(.accountPressed(ProfileSwitcherItem.fixture(userId: "1"))))

await subject.perform(.profileSwitcher(.accountPressed(ProfileSwitcherItem.fixture(userId: "1"))))

authRepository.activeAccount = .fixture(profile: .fixture(userId: "42"))

authRepository.altAccounts = [

.fixture(),

]

authRepository.vaultTimeout = [

"1": .fiveMinutes,

"42": .immediately,

]

claude · 2025-11-28T18:00:20Z

BitwardenShared/UI/Vault/Vault/AutofillList/VaultAutofillListProcessorTests.swift

+        }
+
+        subject.state.profileSwitcherState.isVisible = true
+        await subject.perform(.profileSwitcher(.accountPressed(ProfileSwitcherItem.fixture(userId: "1"))))


❌ Critical: Test setup ordering violation

Same issue as VaultItemSelectionProcessorTests - mock data (lines 201-208) is configured AFTER the action is performed (line 200).

Move lines 201-208 above line 200 to ensure mocks are configured before the test executes.

Suggested change

await subject.perform(.profileSwitcher(.accountPressed(ProfileSwitcherItem.fixture(userId: "1"))))

await subject.perform(.profileSwitcher(.accountPressed(ProfileSwitcherItem.fixture(userId: "1"))))

authRepository.activeAccount = .fixture(profile: .fixture(userId: "42"))

authRepository.altAccounts = [

.fixture(),

]

authRepository.vaultTimeout = [

"1": .fiveMinutes,

"42": .immediately,

]

KatherineInCode

On the whole, it looks good, aside from a small thing I mentioned. And the comments Claude generated noting the mock/test order...while it appears to be that way in the original test, I do find it curious. It might be worth adding a comment to them to explain why the order is the way it is?

KatherineInCode · 2025-12-04T20:24:34Z

BitwardenShared/UI/Vault/Vault/VaultItemSelection/VaultItemSelectionProcessorTests.swift

+            throw XCTSkip("This test requires iOS 26 or later")
+        }
+
+        subject.state.profileSwitcherState.isVisible = true


⛏️ Doesn't the new profile switcher obviate the need for tracking the state visibility this way?

…l-account-switcher-visibility-tests

claude · 2025-12-15T17:45:08Z

Overall Assessment: APPROVE

Reviewed comprehensive iOS 26 test coverage additions for account switcher visibility across 5 processor test files.

Summary:
This PR successfully adds iOS 26-specific test variants for account switcher visibility behavior. The changes follow established patterns, use proper iOS version gating, and maintain consistency with existing test structure. All changes are test-only with no production code modifications.

Test Coverage Added:

Landing: 16 new iOS 26 test cases
VaultUnlock: 19 new iOS 26 test cases
VaultList: 9 new iOS 26 test cases
VaultAutofillList: 2 new iOS 26 test cases
VaultItemSelection: 3 new iOS 26 test cases

Positive Observations:

Proper use of #available(iOS 26, *) version checks with descriptive XCTSkip messages
Consistent naming convention using _iOS26 suffix for variant tests
Appropriate verification that coordinator.routes.contains(.dismiss) for sheet dismissal on iOS 26
Tests properly grouped and follow test ordering guidelines from Testing.md
All tests use async/await appropriately
Mock setup generally follows Arrange-Act-Assert pattern

Minor Observation (Not Blocking):
In some test files (particularly VaultItemSelectionProcessorTests.swift and VaultAutofillListProcessorTests.swift), there are a few instances where state setup occurs before mock configuration. While functionally correct, a more consistent pattern would be:

Configure all repository/service mocks
Set subject state
Perform the action
Assert results

Example from VaultItemSelectionProcessorTests.swift:167-193:

// Current order works but could be clearer:
subject.state.profileSwitcherState.isVisible = true  // State set first
authRepository.activeAccount = ...                    // Then mocks
authRepository.altAccounts = ...
authRepository.vaultTimeout = ...
await subject.perform(...)                            // Then action

// Suggested (more explicit Arrange-Act-Assert):
authRepository.activeAccount = ...                    // Mocks first
authRepository.altAccounts = ...
authRepository.vaultTimeout = ...
subject.state.profileSwitcherState.isVisible = true  // State second
await subject.perform(...)                            // Action last

This is a stylistic preference for improved readability and doesn't affect test correctness.

Recommendation: APPROVE - This PR meets quality standards and adds valuable test coverage for iOS 26 compatibility.

LRNcardozoWDF added 3 commits November 11, 2025 03:35

Merge branch 'main' into cmcg/pm-25906-Backfill-account-switcher-visi…

1d12b88

…bility-tests

Merge branch 'main' into cmcg/pm-25906-Backfill-account-switcher-visi…

b98dece

…bility-tests

pm-25906 Add tests

d95a520

LRNcardozoWDF requested review from a team and matt-livefront as code owners November 28, 2025 04:40

Merge branch 'main' into cmcg/pm-25906-Backfill-account-switcher-visi…

f4d3d15

…bility-tests

claude bot reviewed Nov 28, 2025

View reviewed changes

pm-25906 Remove TODOs

bece6c9

claude bot reviewed Nov 28, 2025

View reviewed changes

KatherineInCode reviewed Dec 4, 2025

View reviewed changes

LRNcardozoWDF added 2 commits December 15, 2025 15:32

Merge remote-tracking branch 'origin/main' into cmcg/pm-25906-Backfil…

c9671e0

…l-account-switcher-visibility-tests

pm-25906 Fix Claude comments

5c1361a

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[PM-25906] Add account switcher visibility tests #2168

[PM-25906] Add account switcher visibility tests #2168

LRNcardozoWDF commented Nov 28, 2025 •

edited by atlassian bot

Loading

Uh oh!

claude bot commented Nov 28, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Nov 28, 2025 •

edited

Loading

Uh oh!

codecov bot commented Nov 28, 2025

Uh oh!

claude bot Nov 28, 2025

Uh oh!

claude bot Nov 28, 2025

Uh oh!

claude bot Nov 28, 2025

Uh oh!

claude bot Nov 28, 2025

Uh oh!

KatherineInCode left a comment

Uh oh!

KatherineInCode Dec 4, 2025

Uh oh!

claude bot commented Dec 15, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

-        await subject.perform(.profileSwitcher(.accountPressed(ProfileSwitcherItem.fixture(userId: "1"))))
+await subject.perform(.profileSwitcher(.accountPressed(ProfileSwitcherItem.fixture(userId: "1"))))
+authRepository.activeAccount = .fixture(profile: .fixture(userId: "42"))
+authRepository.altAccounts = [
+    .fixture(),
+]
+authRepository.vaultTimeout = [
+    "1": .fiveMinutes,
+    "42": .immediately,
+]

[PM-25906] Add account switcher visibility tests #2168

Are you sure you want to change the base?

[PM-25906] Add account switcher visibility tests #2168

Conversation

LRNcardozoWDF commented Nov 28, 2025 • edited by atlassian bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🎟️ Tracking

📔 Objective

📸 Screenshots

⏰ Reminders before review

🦮 Reviewer guidelines

Uh oh!

claude bot commented Nov 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Review Complete

Uh oh!

github-actions bot commented Nov 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Great job! No new security vulnerabilities introduced in this pull request

Uh oh!

codecov bot commented Nov 28, 2025

Codecov Report

Uh oh!

claude bot Nov 28, 2025

Choose a reason for hiding this comment

Uh oh!

claude bot Nov 28, 2025

Choose a reason for hiding this comment

Uh oh!

claude bot Nov 28, 2025

Choose a reason for hiding this comment

Uh oh!

claude bot Nov 28, 2025

Choose a reason for hiding this comment

Uh oh!

KatherineInCode left a comment

Choose a reason for hiding this comment

Uh oh!

KatherineInCode Dec 4, 2025

Choose a reason for hiding this comment

Uh oh!

claude bot commented Dec 15, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

LRNcardozoWDF commented Nov 28, 2025 •

edited by atlassian bot

Loading

claude bot commented Nov 28, 2025 •

edited

Loading

github-actions bot commented Nov 28, 2025 •

edited

Loading