[QA-2081] Part 1 - Add testTags to Block Auto-fill settings row and blocked-URI field#7149
Open
Corbet-BW wants to merge 1 commit into
Open
[QA-2081] Part 1 - Add testTags to Block Auto-fill settings row and blocked-URI field#7149Corbet-BW wants to merge 1 commit into
Corbet-BW wants to merge 1 commit into
Conversation
…I field Add BlockAutoFillButton to the Autofill settings 'Block autofill' row and BlockedUriEntry to the add/edit blocked-URI dialog field, replacing the text-/class-based Appium locators in bitwarden/test with stable resource-ids. The per-row overflow button keeps the shared static 'Options' testTag: every existing repeating list (RecordedLogs, VaultItemListing) uses a shared static tag, and per-item resolution would require a dynamic testTag with no precedent in the app. Per-URI row scoping stays on the test side.
github-actions
Bot
added
app:password-manager
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7149 +/- ##
==========================================
- Coverage 86.76% 86.25% -0.52%
==========================================
Files 868 912 +44
Lines 63975 65588 +1613
Branches 9585 9600 +15
==========================================
+ Hits 55511 56575 +1064
- Misses 5023 5570 +547
- Partials 3441 3443 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Corbet-BW
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
QA-2081
📔 Objective
Add stable
testTags to the Block Auto-fill screens so automation can drop brittle text-/class-based Appium locators for stableresource-ids:BlockAutoFillButton— the "Block autofill" row in Autofill settings (AutoFillScreen.kt), matching the siblingDefaultUriMatchDetectionChooser.BlockedUriEntry— the add/edit blocked-URI dialog field (AddEditBlockedUriDialog.kt), viaBitwardenTextField'stextFieldTestTagparam so the tag lands on the inner EditText.The per-row overflow ("...") button keeps the shared static
OptionstestTag. Every repeating list in the app (RecordedLogs, VaultItemListing) uses a shared static tag; per-item resolution would require a dynamic testTag with no precedent in the app, so per-URI row scoping stays on the test side.Test-side locator swaps (bitwarden/test) will follow once a build with these tags ships.
📸 Screenshots
N/A — no visual change.