[PM-37916] feat: Add titleExtraLarge typography and apply to Premium header#6962
Open
SaintPatrck wants to merge 1 commit into
Conversation
…header Introduce a Title Extra-Large design token (DM Sans SemiBold, 24/28) to the shared `:ui` typography scale and adopt it for the Premium plan header on the Plan screen so the heading matches the Web design.
github-actions
Bot
added
app:password-manager
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## premium-upgrade/align-subscription-card-with-web #6962 +/- ##
====================================================================================
- Coverage 86.45% 86.24% -0.22%
====================================================================================
Files 869 872 +3
Lines 63422 63580 +158
Branches 9189 9189
====================================================================================
- Hits 54834 54832 -2
- Misses 5428 5588 +160
Partials 3160 3160
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
SaintPatrck
added
the
ai-review-vnext
SaintPatrck
changed the title
SaintPatrck
added
t:tech-debt
SaintPatrck
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
PM-37916
Parent PR: #6961
📔 Objective
Design has introduced a new Title Extra-Large token (DM Sans SemiBold, 24/28) to bring the Android typography scale in line with Web. The Premium plan header is its first consumer — the existing
titleLarge(19/28) was a touch undersized against the Web design.This adds
titleExtraLargeto the shared:uitypography scale (slotted abovetitleLargeso the data class reads in descending visual prominence, matching howdisplayLargeprecedesdisplayMedium) and switchesSubscriptionHeaderon the Plan screen to consume it. Other screens are untouched.📸 Screenshots