Skip to content

PM-37911: Feat: Update Organization model#6960

Open
david-livefront wants to merge 1 commit into
mainfrom
PM-37911-organization-network-model
Open

PM-37911: Feat: Update Organization model#6960
david-livefront wants to merge 1 commit into
mainfrom
PM-37911-organization-network-model

Conversation

@david-livefront
Copy link
Copy Markdown
Collaborator

@david-livefront david-livefront commented May 21, 2026

🎟️ Tracking

PM-37911

📔 Objective

This PR updates the Organization network model to include significantly more data. This data is required for use with the SDK (coming soon).

@david-livefront david-livefront requested a review from a team as a code owner May 21, 2026 19:07
@github-actions github-actions Bot added app:password-manager Bitwarden Password Manager app context app:authenticator Bitwarden Authenticator app context t:feature Change Type - Feature Development labels May 21, 2026
@david-livefront david-livefront force-pushed the PM-37911-organization-network-model branch from aee1dd1 to 2f37379 Compare May 21, 2026 19:10
@codecov
Copy link
Copy Markdown

codecov Bot commented May 21, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.34%. Comparing base (c6bef62) to head (0851a91).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6960   +/-   ##
=======================================
  Coverage   86.34%   86.34%           
=======================================
  Files         872      872           
  Lines       63485    63485           
  Branches     9187     9187           
=======================================
  Hits        54816    54816           
  Misses       5510     5510           
  Partials     3159     3159           
Flag Coverage Δ
app-data 17.05% <100.00%> (ø)
app-ui-auth-tools 19.07% <0.00%> (ø)
app-ui-platform 16.48% <0.00%> (ø)
app-ui-vault 27.91% <0.00%> (ø)
authenticator 6.23% <0.00%> (-0.03%) ⬇️
lib-core-network-bridge 4.08% <0.00%> (+0.01%) ⬆️
lib-data-ui 1.15% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@david-livefront david-livefront force-pushed the PM-37911-organization-network-model branch 3 times, most recently from f6215d2 to 0d72f25 Compare May 21, 2026 20:54
@david-livefront david-livefront force-pushed the PM-37911-organization-network-model branch from 0d72f25 to 0851a91 Compare May 21, 2026 21:09
@SaintPatrck SaintPatrck added the ai-review-vnext Request a Claude code review using the vNext workflow label May 22, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 22, 2026

🤖 Bitwarden Claude Code Review

Overall Assessment: APPROVE

This PR expands SyncResponseJson.Profile.Organization and its nested Permissions with the fields needed for upcoming SDK integration, refreshes the KDoc across both types, and introduces three new int-backed enums (MemberDecryptionType, ProductTierType, ProviderType) plus a REVOKED entry in OrganizationStatusType. The existing wire format is preserved: the old shouldUseKeyConnector property was renamed to isKeyConnectorEnabled (same keyConnectorEnabled JSON key) and a genuinely new shouldUseKeyConnector property (useKeyConnector JSON key) was added with a false default, leaving the one mapper in SyncResponseJsonExtensions.toOrganization() and all existing call sites in AuthRepositoryImpl, VaultSyncManagerImpl, RootNavViewModel, and RemovePasswordViewModel behaviorally unchanged. Test fixtures, JSON-based service tests, and AuthRepositoryTest were updated consistently with the rename and the new fields.

Code Review Details

No findings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-review-vnext Request a Claude code review using the vNext workflow app:authenticator Bitwarden Authenticator app context app:password-manager Bitwarden Password Manager app context t:feature Change Type - Feature Development

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants