Extract hosted web/ app to private repo + mixed-license root#24
Open
tomcasaburi wants to merge 1 commit into
Open
Extract hosted web/ app to private repo + mixed-license root#24tomcasaburi wants to merge 1 commit into
tomcasaburi wants to merge 1 commit into
Conversation
The hosted MintPass web app (web/) is the SMS-OTP + NFT-mint service for mintpass.org -- abuse-sensitive, cost-bearing, and intended to be closed-source. It was inheriting the repo-root MIT license while sitting in a public repo (anyone could legally clone the whole service). Moved to the private repo bitsocialnet/mintpass-web (full history preserved via subtree split, proprietary LICENSE). This repo now ships only the open-source packages: - challenge -> GPL-3.0-or-later - contracts -> MIT Changes: - remove web/ (80 files) - LICENSE: MIT -> mixed-license explainer - package.json: license MIT -> UNLICENSED (private monorepo root) - README + scripts/llms-config.json: drop web/ references Authorized by cofounder / copyright holder.
|
Warning Review limit reached
More reviews will be available in 46 minutes and 57 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (9)
📒 Files selected for processing (75)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Second of two mintpass PRs (depends conceptually on the new private repo, already created).
This PR deletes
web/from the public repo.web/is the Next.js site+API for mintpass.org. Before merging, repoint that deployment (Vercel/host) to the new private repobitsocialnet/mintpass-web, or mintpass.org will break on its next build. (No CI/workspace build depends onweb/, so the monorepo build/test is unaffected.)Why
web/is the SMS-OTP + NFT-mint hosted service — abuse-sensitive, cost-bearing, and meant to be closed-source. It was inheriting the root MIT license in a public repo, so anyone could legally clone the entire service. This aligns mintpass with the spam-blocker pattern (public packages + private server).What moved
web/→ private repobitsocialnet/mintpass-web(full history preserved viagit subtree split; proprietaryLICENSE.md;UNLICENSED).Changes here
web/(80 files)LICENSE: MIT → mixed-license explainer (challenge GPL-3.0-or-later, contracts MIT, web proprietary/elsewhere)package.json:licenseMIT →UNLICENSED(private monorepo root, mirrors spam-blocker)README.md+scripts/llms-config.json: dropweb/referencesAuthorized by cofounder. Licensing strategy, not legal advice.
Note
High Risk
Deleting
web/breaks mintpass.org unless production deploy is repointed to the private web repository before merge; licensing changes are broad but the operational risk is deployment.Overview
This PR removes the entire
web/tree from the public monorepo (Next.js UI, API routes, Twilio/SMS, KV helpers, smoke scripts, and generatedweb/public/llms*assets). The hosted mintpass.org SMS-OTP and minting service is documented as proprietary and maintained only in the privatebitsocialnet/mintpass-webrepo.Licensing and docs are updated to match: root
LICENSEbecomes a mixed-license index (challenge/GPL-3.0-or-later,contracts/MIT, web elsewhere); rootpackage.jsonlicensechanges from MIT toUNLICENSED;README.mdandscripts/llms-config.jsondropweb/from structure, getting-started, and LLM doc outputs (no more copies underweb/public/).Deploy impact: merging without repointing the mintpass.org deployment to the private web repo will break the live site on the next build; open-source
contractsandchallengeworkspaces are unchanged.Reviewed by Cursor Bugbot for commit 3f177c1. Bugbot is set up for automated code reviews on this repo. Configure here.