Update to version 1.0.0 and migrate to Dart 3.0 / Flutter 3.41#278
Open
Abdulrahman-Al-Sheikh wants to merge 1 commit intobitsdojo:masterfrom
Open
Update to version 1.0.0 and migrate to Dart 3.0 / Flutter 3.41#278Abdulrahman-Al-Sheikh wants to merge 1 commit intobitsdojo:masterfrom
Abdulrahman-Al-Sheikh wants to merge 1 commit intobitsdojo:masterfrom
Conversation
* Upgrade SDK constraints to `>=3.0.0 <4.0.0` * Update dependencies: `win32` to `^6.0.1`, `ffi` to `^2.2.0`, and `plugin_platform_interface` to `^2.1.8` * Use `base` class modifier for FFI `Struct` classes to comply with Dart 3 requirements * Update Windows implementation to use `HWND`, `HMONITOR`, `WPARAM`, and `LPARAM` types from `win32` package * Refactor native API lookups and message passing to use new `win32` type definitions * Update `window_button.dart` to use `Color.withValues(alpha: ...)` instead of `withOpacity` * General code cleanup, formatting, and improved import organization across platform implementations
nvi9
reviewed
Apr 22, 2026
| abstract class DesktopWindow { | ||
| DesktopWindow(); | ||
| int? get handle; | ||
| HWND? get handle; |
There was a problem hiding this comment.
Probably better keep this with type int? as DesktopWindow is used on other platforms too, not just on Windows. Also importing win32 in a platform interface is a bit questionable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
>=3.0.0 <4.0.0win32to^6.0.1,ffito^2.2.0, andplugin_platform_interfaceto^2.1.8baseclass modifier for FFIStructclasses to comply with Dart 3 requirementsHWND,HMONITOR,WPARAM, andLPARAMtypes fromwin32packagewin32type definitionswindow_button.dartto useColor.withValues(alpha: ...)instead ofwithOpacity