Fix sequence preservation#4195
Open
kajoseph wants to merge 3 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes a transaction input sequencing regression where calling associateInputs() after changing input sequence numbers (e.g. via enableRBF()) could reset sequences back to defaults, leading to downstream signature/verification failures.
Changes:
- Preserve existing
sequenceNumberwhenassociateInputs()replaces an input with one reconstructed from a UTXO. - Refactor
transaction.jsloops/vars across libs to satisfy current lint rules (e.g., replaceforEachwithfor...of). - Update ESLint config for CommonJS package JS files (reduce friction with
requireusage and bitwise ops).
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/bitcore-lib/lib/transaction/transaction.js | Lint-driven refactors (loop style, minor cleanups) in core transaction implementation. |
| packages/bitcore-lib-ltc/lib/transaction/transaction.js | Apply sequence preservation in associateInputs() plus lint updates. |
| packages/bitcore-lib-doge/lib/transaction/transaction.js | Apply sequence preservation in associateInputs() plus lint updates (one lint-breaking semicolon remains). |
| packages/bitcore-lib-cash/lib/transaction/transaction.js | Apply sequence preservation in associateInputs() plus lint updates. |
| eslint.config.mjs | Adjust rules for CommonJS JS sources (warn on require-imports, disable no-bitwise for those packages). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Trying to associateInputs after the sequence number has been changed from the default (e.g.
enableRBF()is called) will result in the sequence number on the inputs being reset to the default, which will cause downstream issues when applying signatures and/or verifying transaction proposals.Changelog
transaction.jsfiles for each lib - necessary for the precommits to pass.Testing Notes
I ran across this issue by creating a DOGE tx proposal with rbf enabled. I then got a BAD_SIGNATURES error when signing the txp.
Checklist