Fix client server number rounding by kajoseph · Pull Request #4188 · bitpay/bitcore

kajoseph · 2026-07-03T17:12:11Z

Description

CWC's toHex util provided inconsistent conversions for large Numbers.

Changelog

Adds a special conversion for Numbers in CWC's toHex util function.
Adds round-trip tests for TXPs in BWC.
Adds typing to BWS's getSendMaxInfo() methods
Adds numberFormat params to getTx and getSendMaxInfo methods in both BWC & BWS
Fixes client-side verification method(s) when verifying string/hex numbers.
Fixes some incidental issues:
- Fixed bitcore-client's deleteWallet idempotence
- Fixed ci.sh local test runner creating the build dirs as root

Testing Notes

Add any helpful notes for reviewers to test your code here.

Checklist

I have read CONTRIBUTING.md and verified that this PR follows the guidelines and requirements outlined in it.

…ghout flow

…d try-catch to before all hook for debugging ci pipeline

Copilot

Pull request overview

This PR aims to make large-number handling consistent across crypto-wallet-core (CWC), bitcore-wallet-service (BWS), and bitcore-wallet-client (BWC), primarily by normalizing Number→hex conversion and introducing a numberFormat parameter to control how tx-building numeric fields are represented over the API (e.g., hex strings to preserve precision). It also adds round-trip tests for tx proposals and includes a few operational/idempotence fixes.

Changes:

Update CWC toHex to convert number inputs via a locale-formatted decimal string before BigInt() conversion, plus add tests for large-number behavior.
Add numberFormat plumbing across BWS routes/server methods and BWC client methods, including formatting of tx proposal numeric fields and send-max info.
Add BWC round-trip tx proposal integration tests; make bitcore-client wallet deletion idempotent; prevent local CI docker runs from creating root-owned build dirs.

Reviewed changes

Copilot reviewed 26 out of 27 changed files in this pull request and generated 6 comments.

Show a summary per file

File	Description
packages/crypto-wallet-core/test/utils.test.ts	Adds regression tests around `toHex` behavior for large Numbers.
packages/crypto-wallet-core/src/utils/index.ts	Adjusts `toHex` to normalize `number` inputs before `BigInt()` conversion.
packages/crypto-wallet-core/src/utils/bigint.ts	Adds bigint helpers (`isEqual`, `BigIntTry`) for cross-format comparisons/conversion.
packages/crypto-wallet-core/src/transactions/index.ts	Tightens typing for transaction provider proxy methods.
packages/bitcore-wallet-service/src/types/server.d.ts	Introduces option typings for send-max info and number formatting.
packages/bitcore-wallet-service/src/lib/server.ts	Adds number formatting support to `getTx` and `getSendMaxInfo`; refactors internal helpers.
packages/bitcore-wallet-service/src/lib/routes/walletdata.ts	Accepts `numberFormat` on `/v1/sendmaxinfo` and aligns feeLevel typing.
packages/bitcore-wallet-service/src/lib/routes/transactions.ts	Passes `numberFormat` through on tx proposal fetch route(s).
packages/bitcore-wallet-service/src/lib/common/utils.ts	Adds a generic number conversion helper used by send-max formatting.
packages/bitcore-wallet-service/src/lib/chain/xrp/index.ts	Adds typings for send-max opts.
packages/bitcore-wallet-service/src/lib/chain/sol/index.ts	Adds typings and adjusts amount validation to rely on `toHex` throwing behavior.
packages/bitcore-wallet-service/src/lib/chain/index.ts	Adds typings for send-max proxy method.
packages/bitcore-wallet-service/src/lib/chain/eth/index.ts	Adds typings and adjusts amount validation; normalizes gasLimit numeric addition.
packages/bitcore-wallet-service/src/lib/chain/doge/index.ts	Adds typings for send-max opts.
packages/bitcore-wallet-service/src/lib/chain/btc/index.ts	Adds typings for send-max opts.
packages/bitcore-wallet-client/test/helpers.ts	Updates explorer mock to better support EVM scenarios.
packages/bitcore-wallet-client/test/api.test.ts	Updates many tests to use bigint/hex formats and adds round-trip txp tests.
packages/bitcore-wallet-client/src/lib/verifier.ts	Uses bigint-aware equality for output amounts and fees during proposal verification.
packages/bitcore-wallet-client/src/lib/common/utils.ts	Exposes CWC Utils via BWC Utils for reuse.
packages/bitcore-wallet-client/src/lib/api.ts	Adds `numberFormat` query usage and bigint parsing for send-max responses; refactors createTxProposal signature.
packages/bitcore-node/test/integration/models/wallet.test.ts	Minor typing/import + lifecycle adjustments in integration test.
packages/bitcore-client/src/wallet.ts	Makes `deleteWallet` idempotent when default wallet path is missing.
packages/bitcore-client/src/storage/textFile.ts	Improves invalid-path error message and makes delete idempotent if wallet file missing.
packages/bitcore-client/src/storage/level.ts	Improves invalid-path error message to include path.
packages/bitcore-cli/src/commands/transaction.ts	Tightens destination tag validation and switches fee values to bigint; renders nonce as BigInt.
docker-compose.test.local.yml	Runs docker test service as host UID/GID to avoid root-owned artifacts.
ci.sh	Exports DOCKER_UID/DOCKER_GID for local docker-compose runs.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

…ls bigint tests added

Copilot

Pull request overview

Copilot reviewed 27 out of 28 changed files in this pull request and generated 9 comments.

+      //  (12345678901234567890123)
+      //    .toLocaleString('fullwide', { useGrouping: false }) => '12345678901234568000000' => ✔ Produces a string representation of the JavaScript rounded integer that can be directly converted to BigInt
+
+      input = input.toLocaleString('fullwide', { useGrouping: false });


+export function isEqual(int1: BigIntLike, int2: BigIntLike): boolean {
+  if (int1 == int2) return true;
+  if (!isBigIntLike(int1) || !isBigIntLike(int2)) return false;
+  try {
+    return BigInt(int1) === BigInt(int2);
+  } catch {
+    // BigInt() may throw for integer floats (e.g. '1.0') and/or scientific notation (e.g. '1e0')
+    int1 = int1.toString().includes('e') ? Number(int1).toString() : int1.toString();
+    int2 = int2.toString().includes('e') ? Number(int2).toString() : int2.toString();
+    const [left1, right1 = '0'] = int1.toString().split('.');
+    const [left2, right2 = '0'] = int2.toString().split('.');
+    if (BigInt(left1) !== BigInt(left2) || BigInt(right1) !== BigInt(right2)) return false;
+    return Number(int1) === Number(int2); // Note: NaN values are captured above in isBigIntLike()
+  }
+}


+      expect(BI.isEqual('Infinity', Infinity)).to.equal(true);
+      expect(BI.isEqual('-Infinity', -Infinity)).to.equal(true);


+    it('should return true when both values are invalid but loosely equal', function() {
+      expect(BI.isEqual('invalid', 'invalid')).to.equal(true);
+      expect(BI.isEqual(null, null)).to.equal(true);
+      expect(BI.isEqual(undefined, undefined)).to.equal(true);
+      expect(BI.isEqual(null, undefined)).to.equal(true);
+      expect(BI.isEqual('', '')).to.equal(true);
+    });


+      checkNumberFormat(req.query.numberFormat, res);
      req.body.txProposalId = req.params['id'];
+      req.body.numberFormat = req.query.numberFormat;


+      if (query.feeLevel) opts.feeLevel = query.feeLevel;
      if (query.excludeUnconfirmedUtxos == '1') opts.excludeUnconfirmedUtxos = true;
      if (query.returnInputs == '1') opts.returnInputs = true;
+      if (query.numberFormat) opts.numberFormat = query.numberFormat as 'hex' | 'number' | 'string';


+      case 'string':
+        convertFn = (n) => typeof n === 'string' && n.startsWith('0x') ? BigInt(n).toString() : n.toString();
+        break;


kajoseph added 2 commits July 3, 2026 13:04

fix toHex precision for Number inputs

13fa3cd

BWC: Add round trip tests for txps --> Enforce number precision throu…

22146d2

…ghout flow

kajoseph added BWC This pull request modifies the bitcore-wallet-client package BWS This pull request modifies the bitcore-wallet-service package CWC This pull request modifies the crypto-wallet-core package labels Jul 3, 2026

kajoseph added 4 commits July 3, 2026 14:40

adjust bitcore-cli's tx creation for bwc type changes

577164d

fix xrp dest tag validation; safer fee rounding (ceiling)

8dfcebf

use testnet instead of regtest in tests

7daf18e

fix local docker tests user; fix bitcore-client deleteWallet idempotence

0339047

kajoseph added the BCC This pull request modifies the bitcore-client package label Jul 4, 2026

kajoseph added 3 commits July 4, 2026 11:41

fix deleteWallet idempotence on error; cleanup before/after hooks; ad…

5427ad4

…d try-catch to before all hook for debugging ci pipeline

still bomb on before all error

e8ea4b3

fix textfile deleteWallet idempotence

8f1ffa6

kajoseph requested a review from Copilot July 5, 2026 13:18

Copilot started reviewing on behalf of kajoseph July 5, 2026 13:18 View session

Copilot AI reviewed Jul 5, 2026

View reviewed changes

kajoseph added 2 commits July 6, 2026 10:40

feedback: better isEqual, various input validation hardening; CWC uti…

d36c7c2

…ls bigint tests added

fix biginttry test for boolean

0baf871

kajoseph requested a review from Copilot July 6, 2026 15:16

Copilot started reviewing on behalf of kajoseph July 6, 2026 15:16 View session

Copilot AI reviewed Jul 6, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix client server number rounding#4188

Fix client server number rounding#4188
kajoseph wants to merge 11 commits into
bitpay:masterfrom
kajoseph:fixClientServerNumberRounding

kajoseph commented Jul 3, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

		expect(BI.isEqual('Infinity', Infinity)).to.equal(true);
		expect(BI.isEqual('-Infinity', -Infinity)).to.equal(true);

Uh oh!

Conversation

kajoseph commented Jul 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Changelog

Testing Notes

Checklist

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

kajoseph commented Jul 3, 2026 •

edited

Loading