Skip to content

[FIX] Add backward compatibility with sjcl encryption #4096

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
gabrielbazan7 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[FIX] Add backward compatibility with sjcl encryption #4096

gabrielbazan7 wants to merge 1 commit into from
+224 −19

Conversation

@gabrielbazan7
Copy link
Contributor

@gabrielbazan7 gabrielbazan7 commented Jan 29, 2026

Description

Adds backward compatibility with sjcl encryption library for decrypting bwc < v11 already encrypted keys

Changelog

  • Add sjcl fallback decryption in Key class methods
  • Add sjcl fallback decryption in Utils class methods
  • Add unit tests
  • revert _oldCopayDecrypt changes

Testing Notes

Checklist

  • I have read CONTRIBUTING.md and verified that this PR follows the guidelines and requirements outlined in it.
  • I have added the appropriate package tag(s) (e.g. BWC if modifying the bitcore-wallet-client package, CLI if modifying the bitcore-cli package, etc.)
  • I have verified that this is not an existing PR (open or closed)

@kajoseph kajoseph added the BWC This pull request modifies the bitcore-wallet-client package label Jan 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

BWC This pull request modifies the bitcore-wallet-client package

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@gabrielbazan7 @kajoseph