-
Notifications
You must be signed in to change notification settings - Fork 10
android/ios: move static fields into Rust layer #807
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
snowp
wants to merge
15
commits into
main
Choose a base branch
from
avoid-static-field-conversion
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Size Comparison Report (x86_64)
|
5ff1732 to
8cbf009
Compare
8a95e1b to
9ceff13
Compare
Android Benchmark Results
Allocations
Timing
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change a number of fields would be passed through to the Rust layer on every log call, resulting in extra JNI calls and string allocations. This PR moves a number of these fields into Rust allowing us to store them as reusable strings.
This also has the benefit that we can read these directly during crash reporting and not pass these through from the platform layer
CHANGELOG.md's "Unreleased" section has been updated, if applicable.