You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Replace usize with u32 or smaller appropriate type. The max size integer needed by the CKTAP protocol is a u32 so the usize type shouldn't be part of the public API of this library. Removing the usize type also removes the need to convert from usize to smaller types in the uniFFI language bindings.
Notes to the reviewers
This is a BREAKING CHANGE.
Changelog notice
Replace usize with u32 or smaller appropriate types in the public API.
Rust side cleanup looks good but since PR description also calls out UniFFI bindings I think maybe the corresponding cktap-ffi status+error types still need to be updated as well for the generated Swift API to fully reflect this change. For example I think this might need to happen in sats_card.rs:
Rust side cleanup looks good but since PR description also calls out UniFFI bindings I think maybe the corresponding cktap-ffi status+error types still need to be updated as well for the generated Swift API to fully reflect this change. For example I think this might need to happen in sats_card.rs:
Oh shoot! I should have caught that. Fixed now and also rebased to pickup changes from master.
Rust side cleanup looks good but since PR description also calls out UniFFI bindings I think maybe the corresponding cktap-ffi status+error types still need to be updated as well for the generated Swift API to fully reflect this change. For example I think this might need to happen in sats_card.rs:
Oh shoot! I should have caught that. Fixed now and also rebased to pickup changes from master.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Replace
usizewithu32or smaller appropriate type. The max size integer needed by the CKTAP protocol is au32so theusizetype shouldn't be part of the public API of this library. Removing theusizetype also removes the need to convert fromusizeto smaller types in the uniFFI language bindings.Notes to the reviewers
This is a BREAKING CHANGE.
Changelog notice
Checklists
All Submissions:
cargo fmtandcargo clippybefore committingNew Features:
Bugfixes: