-
Notifications
You must be signed in to change notification settings - Fork 7
feat: add frigate electrum based RPC methods #16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
sdmg15
wants to merge
5
commits into
bitcoindevkit:master
Choose a base branch
from
sdmg15:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
4c80f38
feat: add `server.version`, `blockchain.silentpayments.subscribe` and…
sdmg15 3a63c94
fix: consistency with current implementation
sdmg15 99312db
feat: allow gen_pending_request_types to support cfg feature attribute
sdmg15 df15c6b
fix: remove server.version, make comment doc clear about supported ve…
sdmg15 120356e
fix: doc comments and logic fix
sdmg15 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -17,7 +17,7 @@ pub trait RequestExt: Request + Sized { | |
| } | ||
|
|
||
| macro_rules! gen_pending_request_types { | ||
| ($($name:ident),*) => { | ||
| ($($(#[$attr:meta])* $name:ident),* $(,)?) => { | ||
| /// A successfully handled request and its decoded server response. | ||
| /// | ||
| /// This enum is returned when a request has been fully processed and the server replied | ||
|
|
@@ -33,10 +33,13 @@ macro_rules! gen_pending_request_types { | |
| /// [`Event::Response`]: crate::Event::Response | ||
| #[derive(Debug, Clone)] | ||
| pub enum CompletedRequest { | ||
| $($name { | ||
| req: crate::request::$name, | ||
| resp: <crate::request::$name as Request>::Response, | ||
| }),*, | ||
| $( | ||
| $(#[$attr])* | ||
| $name { | ||
| req: crate::request::$name, | ||
| resp: <crate::request::$name as Request>::Response, | ||
| }, | ||
| )* | ||
| } | ||
|
|
||
| /// A request that received an error response from the Electrum server. | ||
|
|
@@ -53,23 +56,32 @@ macro_rules! gen_pending_request_types { | |
| /// [`Event::ResponseError`]: crate::Event::ResponseError | ||
| #[derive(Debug, Clone)] | ||
| pub enum FailedRequest { | ||
| $($name { | ||
| req: crate::request::$name, | ||
| error: ResponseError, | ||
| }),*, | ||
| $( | ||
| $(#[$attr])* | ||
| $name { | ||
| req: crate::request::$name, | ||
| error: ResponseError, | ||
| }, | ||
| )* | ||
| } | ||
|
|
||
| impl core::fmt::Display for FailedRequest { | ||
| fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result { | ||
| match self { | ||
| $(Self::$name { req, error } => write!(f, "Server responsed to {:?} with error: {}", req, error)),*, | ||
| $( | ||
| $(#[$attr])* | ||
| Self::$name { req, error } => { | ||
| write!(f, "Server responsed to {:?} with error: {}", req, error) | ||
| } | ||
| )* | ||
| } | ||
| } | ||
| } | ||
|
|
||
| impl std::error::Error for FailedRequest {} | ||
|
|
||
| $( | ||
| $(#[$attr])* | ||
| impl RequestExt for crate::request::$name { | ||
| fn into_completed(self, resp: <Self as Request>::Response) -> CompletedRequest { | ||
| CompletedRequest::$name { req: self, resp } | ||
|
|
@@ -103,7 +115,9 @@ gen_pending_request_types! { | |
| GetFeeHistogram, | ||
| Banner, | ||
| Ping, | ||
| Custom | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. any reason you dropped Custom here?
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Thanks for catching this, I chose the wrong |
||
| Custom, | ||
| #[cfg(feature = "frigate")] SpSubscribe, | ||
| #[cfg(feature = "frigate")] SpUnsubscribe | ||
| } | ||
|
|
||
| type Handler = | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.