Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
serde_jsonrequires eitherstdorallocfeature enabled. We just enableallocas we don't need the features thatstdprovides.Notes to the reviewers
allocis just a subset ofstd.json_serdehasfrom_reader()&to_writer()methods ifstdis enabled. We aren't using those methods so just havingallocis fine.I'm also not sure why an explicit
alloccargo feature flag is needed inserde_json. They can just have an internal prelude based on whether thestdfeature is enabled.Checklists
All Submissions: