Skip to content

Conversation

@evanlinjin
Copy link
Member

@evanlinjin evanlinjin commented Jan 21, 2026

Description

serde_json requires either std or alloc feature enabled. We just enable alloc as we don't need the features that std provides.

Notes to the reviewers

alloc is just a subset of std. json_serde has from_reader() & to_writer() methods if std is enabled. We aren't using those methods so just having alloc is fine.

I'm also not sure why an explicit alloc cargo feature flag is needed in serde_json. They can just have an internal prelude based on whether the std feature is enabled.

Checklists

All Submissions:

`serde_json` requires either `std` or `alloc` feature enabled.
@evanlinjin evanlinjin force-pushed the fix/no-std-serde-json branch from dc114b9 to 546b07e Compare January 21, 2026 09:29
@evanlinjin evanlinjin marked this pull request as ready for review January 21, 2026 09:43
Copy link
Member

@luisschwab luisschwab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 546b07e

Copy link
Contributor

@oleonardolima oleonardolima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 546b07e

@oleonardolima oleonardolima moved this to Needs Review in BDK Chain Jan 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Needs Review

Development

Successfully merging this pull request may close these issues.

3 participants