Skip to content

chore: remove unused tap dependency - #315

Merged
tvpeter merged 1 commit into
bitcoindevkit:masterfrom
vadim-anfv:chore/remove-tap-dependency
Aug 24, 2026
Merged

chore: remove unused tap dependency#315
tvpeter merged 1 commit into
bitcoindevkit:masterfrom
vadim-anfv:chore/remove-tap-dependency

Conversation

@vadim-anfv

Copy link
Copy Markdown
Contributor

Closes #314

Description

Removes the unused tap dependency, per @tvpeter's decision.

Changelog notice

  • Removed the unused tap dependency

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

@codecov

codecov Bot commented Aug 18, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 57.45%. Comparing base (e7223e5) to head (7e8b960).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #315   +/-   ##
=======================================
  Coverage   57.45%   57.45%           
=======================================
  Files          22       22           
  Lines        3695     3695           
=======================================
  Hits         2123     2123           
  Misses       1572     1572           
Flag Coverage Δ
rust 57.45% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tvpeter tvpeter left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 7e8b960

@tvpeter
tvpeter merged commit f8738d8 into bitcoindevkit:master Aug 24, 2026
9 checks passed
@github-project-automation github-project-automation Bot moved this to Done in BDK-CLI Aug 24, 2026
@vadim-anfv
vadim-anfv deleted the chore/remove-tap-dependency branch August 24, 2026 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Use or delete the tap dependency

2 participants