BIP-375: correct labeled test vectors to include labeled-spend key in PSBT_OUT_SP_V0_INFO#2207
Open
macgyver13 wants to merge 2 commits into
Open
BIP-375: correct labeled test vectors to include labeled-spend key in PSBT_OUT_SP_V0_INFO#2207macgyver13 wants to merge 2 commits into
macgyver13 wants to merge 2 commits into
Conversation
Now PSBT_OUT_SP_V0_INFO provides labeled-spend public key not the base-spend public key. Modify test vector with labeled-spend key to the same recipient from: two sp outputs - output 0 uses label=3 / output 1 uses label=1 to: three sp outputs (same scan key) - output 0 uses label=1, outputs 1 and 2 uses label=2 (same spend key) This vector excercises the BIP375 sorting outputs with same scan key properly. The next commit will fix the validation logic and address this failing test. bump ChangeLog to 0.1.2
Fix output script validation for silent payment output ordering when multiple outputs share the same scan key (labeled addresses of one recipient).
Member
|
cc BIP Owners for review: @andrewtoth, @achow101, @josibake |
murchandamus
added
Proposed BIP modification
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Includes two changes to align the labeled test vectors and validation reference with BIP-375:
Changed vectors:
Test Runner Output