Skip to content

⬆️ Bump org.bouncycastle:bcprov-jdk18on from 1.80 to 1.84 in /weixin-java-cp#3966

Merged
binarywang merged 3 commits intodevelopfrom
dependabot/maven/weixin-java-cp/org.bouncycastle-bcprov-jdk18on-1.84
Apr 20, 2026
Merged

⬆️ Bump org.bouncycastle:bcprov-jdk18on from 1.80 to 1.84 in /weixin-java-cp#3966
binarywang merged 3 commits intodevelopfrom
dependabot/maven/weixin-java-cp/org.bouncycastle-bcprov-jdk18on-1.84

Conversation

@dependabot
Copy link
Copy Markdown
Contributor

@dependabot dependabot bot commented on behalf of github Apr 18, 2026

Bumps org.bouncycastle:bcprov-jdk18on from 1.80 to 1.84.

Changelog

Sourced from org.bouncycastle:bcprov-jdk18on's changelog.

... (truncated)

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
    You can disable automated security fix PRs for this repo from the Security Alerts page.

Bumps [org.bouncycastle:bcprov-jdk18on](https://github.com/bcgit/bc-java) from 1.80 to 1.84.
- [Changelog](https://github.com/bcgit/bc-java/blob/main/docs/releasenotes.html)
- [Commits](https://github.com/bcgit/bc-java/commits)

---
updated-dependencies:
- dependency-name: org.bouncycastle:bcprov-jdk18on
  dependency-version: '1.84'
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file java Pull requests that update java code labels Apr 18, 2026
@augmentcode
Copy link
Copy Markdown

augmentcode bot commented Apr 18, 2026

🤖 Augment PR Summary

Summary: Updates BouncyCastle org.bouncycastle:bcprov-jdk18on in weixin-java-cp from 1.80 to 1.84.
Why: Dependabot-driven dependency bump to incorporate upstream fixes (and potential security/compatibility improvements).

🤖 Was this summary useful? React with 👍 or 👎

Copy link
Copy Markdown

@augmentcode augmentcode bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. 1 suggestion posted.

Fix All in Augment

Comment augment review to trigger a new review at any time.

Comment thread weixin-java-cp/pom.xml Outdated
<groupId>org.bouncycastle</groupId>
<artifactId>bcprov-jdk18on</artifactId>
<version>1.80</version>
<version>1.84</version>
Copy link
Copy Markdown

@augmentcode augmentcode bot Apr 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

weixin-java-cp/pom.xml:99 — This bumps bcprov-jdk18on to 1.84, but the root pom.xml still manages bcpkix-jdk18on at 1.80; mixing BouncyCastle versions can lead to dependency convergence issues or runtime NoSuchMethodError when multiple modules are used together. Consider aligning the BouncyCastle artifact versions across the build to avoid a split-brain dependency tree.

Severity: medium

Fix This in Augment

🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

该 PR 旨在更新 WxJava 企业微信(weixin-java-cp)模块中使用的 BouncyCastle Provider 依赖版本,以跟进上游安全/兼容性更新。

Changes:

  • weixin-java-cp 模块的 org.bouncycastle:bcprov-jdk18on1.80 升级到 1.84

Comment thread weixin-java-cp/pom.xml
Comment on lines 96 to 100
<dependency>
<groupId>org.bouncycastle</groupId>
<artifactId>bcprov-jdk18on</artifactId>
<version>1.80</version>
<version>1.84</version>
</dependency>
Copy link

Copilot AI Apr 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里把 bcprov-jdk18on 升到 1.84,但根 pom.xml 的 dependencyManagement 里仍固定了 bcpkix-jdk18on 为 1.80。由于其他模块(pay/channel/miniapp 等)依赖 bcpkix-jdk18on(并通过 dependencyManagement 解析版本),当用户同时引入 weixin-java-cp 与这些模块时,Maven 可能会产生 BouncyCastle 版本分裂(bcprov 1.84 vs bcpkix 1.80 及其传递依赖),存在运行期 NoSuchMethodError / ClassNotFound 的风险。建议将 BouncyCastle 版本在父 pom 统一管理(例如抽成 bouncycastle.version 属性,并同时升级 bcpkix-jdk18on 与 bcprov-jdk18on 到同一版本),然后在此处去掉显式 或对齐到同一版本来源。

Copilot uses AI. Check for mistakes.
@binarywang
Copy link
Copy Markdown
Owner

@copilot apply changes based on the comments in this thread

Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 19, 2026

@copilot apply changes based on the comments in this thread

已在 38229b3 中完成以下变更:

  1. 在根 pom.xml<properties> 中添加 bouncycastle.version=1.84
  2. bcpkix-jdk18on(1.80→1.84)和 bcprov-jdk18on 统一纳入根 pom.xml<dependencyManagement>,均使用 ${bouncycastle.version}
  3. 删除 weixin-java-cp/pom.xmlbcprov-jdk18on 的显式版本声明,改为继承父 pom 管理

Copilot AI requested a review from binarywang April 19, 2026 14:31
@binarywang
Copy link
Copy Markdown
Owner

@copilot resolve the merge conflicts in this pull request

Co-authored-by: binarywang <1343140+binarywang@users.noreply.github.com>
Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 20, 2026

@copilot resolve the merge conflicts in this pull request

已在 0a0686b 中完成合并并解决冲突。develop 分支将 bcpkix-jdk18on 直接升至 1.84(硬编码版本),与我们使用 ${bouncycastle.version} 属性的方式有冲突,已保留属性方式并同时保留 bcprov-jdk18on 条目,构建验证通过。

@binarywang binarywang merged commit c1d55c1 into develop Apr 20, 2026
1 check was pending
@binarywang binarywang deleted the dependabot/maven/weixin-java-cp/org.bouncycastle-bcprov-jdk18on-1.84 branch April 20, 2026 02:43
@binarywang binarywang added this to the 4.8.3 milestone Apr 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file java Pull requests that update java code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants