Log warning in console if duplicate ids are detected #142
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Idiomorph relies on ids being unique within the morphed document for two main reasons:
Problem
It's not easy to know when your html documents have duplicate ids, and resultant failures in the morph may be subtle or non-obvious in cause. It would likely take a deep dive into Idiomorph's algorithm with a debugger to identify that the problem is duplicate ids.
Proposition
Idiomorph already knows on startup when you have duplicate ids, so this PR simply prints a warning to the console with a list of them, leaving it up to the user to decide to either address or ignore. I've tried to make the message generic, so that vicarious users of Idiomorph (e.g. Turbo) who may have never heard it can still understand what the problem is, and what to do.
Questions
Closes #141