Fix hx-live take to default to sibling scope#3816
Open
MichaelWest22 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Recent improvements to hx-live have changed the default scope behavior of the take helper. It now defaults to take from the whole page which could be a risky default. The normal take case is to take a class or selection etc from your siblings in a list so it defaults to searching for the class inside the parentElement and removing the class from here and placing it on the selected element. So I've reverted to this old behavior which I think makes more sense.
Corresponding issue:
Testing
Added tests for the default take from sibling case and removed the default from whole page test.
Checklist
masterfor website changes,devforsource changes)
approved via an issue
npm run test) and verified that it succeeded