fix(BBBModal): footer tweaks, docs(BBBModal): enhance story usability#38
Merged
Conversation
Use a controlled trigger-button pattern with a ModalStory wrapper
component to prevent the fixed overlay from covering Storybook's UI.
The modal can now be opened/closed via a button while keeping the
controls panel fully accessible. Syncs with the isOpen arg control
via useEffect and sets ariaHideApp={false} to avoid react-modal
warnings in the iframe context.
options Add more elements to the modal body to enable meaningful testing of the `allowScroll` option. Add a default footer with two buttons to allow testing of footer rendering and the `showDividers` option.
When `noFooter` is true, the footer is still displayed if `footerContent` is provided. Update the footer visibility condition so `noFooter: true` hides the footer regardless of whether `footerContent` is set.
content When `stickyFooter` is set to false, the footer does not correctly position itself below the full modal content and is affected by additional padding. Position the footer below the entire modal content when `stickyFooter` is false, ignoring any additional padding.
The BBBModal background colors are hardcoded as `#fff` instead of using the `colorWhite` CSS variable, causing them to ignore theme overrides. Replace all `#fff` occurrences with `colorWhite`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Addresses a few tweaks for the footer in BBBModal component.
Also, enhances the usability of the story in Storybook for BBBModal, where the modal was being rendered over the Storybook UI and could not be closed.
Closes Issue(s)
Closes #37