feat: add admin backup and restore workflow - #71
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c3cfbc64de
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| from .maintenance_mode import is_active | ||
| if is_active(): | ||
| failed.append('maintenance') |
There was a problem hiding this comment.
Return before running readiness probes during restore
When an orchestrator polls /ready while maintenance is active, this only records a failure and still runs both probes. _probe_data_directory() creates a transient top-level file inside DATA_DIR, so it can race with restore_backup() enumerating and copying persistent files; if the probe deletes that file after enumeration, the restore can fail, and the same race can affect the emergency rollback. The database probe can also reopen the engine after restore_service explicitly disposes it. Return the maintenance 503 before executing either probe.
Useful? React with 👍 / 👎.
Summary
Security and reliability
DATA_DIRand static paths in restrictive, expiring, per-instance temporary namespacesCompatibility
backup create,backup verify, and offline-confirmedbackup restoreremain supportedValidation
1304 passed, 29 skipped, 1 deselectedin the complete Python suite; the deselected Node-dependent Playwright-port assertion passed separately with Node70 passedin the available JavaScript unit suitegit diff --checkpassed/readysmoke test passed