Skip to content

feat: improve saved connection workflows - #69

Merged
bifrost0x merged 10 commits into
mainfrom
dev/discussion-59-ui
Aug 3, 2026
Merged

feat: improve saved connection workflows#69
bifrost0x merged 10 commits into
mainfrom
dev/discussion-59-ui

Conversation

@bifrost0x

Copy link
Copy Markdown
Owner

Summary

Implements the UI scope agreed in Discussion #59.

  • launch complete saved connections directly without flashing the Quick Connect dialog
  • fall back to review when passwords, SSH keys, jump hosts, or authorization require user input
  • add inline SSH key upload and atomic key rename to saved connection management
  • preserve editor state across key operations and provide keyboard-accessible controls
  • use consistent Quick Connect and Saved Connections terminology across all six locales
  • keep the workflow usable at 375 px with appropriate touch targets

Security and compatibility

  • SSH key mutations remain scoped to the authenticated user on the server
  • key rename changes metadata only and records atomic before/after audit values
  • acknowledgements expose key summaries only, never private key content
  • existing profile storage, Socket.IO event names, and CLI behavior remain compatible
  • no database migration or dependency change is included

Validation

  • Python 3.11: 1268 passed, 33 skipped
  • Python 3.14: 1268 passed, 33 skipped
  • JavaScript: 68 passed
  • Playwright: 25 scenarios passed
  • vendored assets verified
  • Docker image build and application factory smoke test passed

@bifrost0x
bifrost0x marked this pull request as ready for review August 3, 2026 08:38
@bifrost0x
bifrost0x merged commit da5b59d into main Aug 3, 2026
14 of 15 checks passed
@bifrost0x
bifrost0x deleted the dev/discussion-59-ui branch August 3, 2026 08:39

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d1373164ec

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +139 to +141
this.setKeys(exists
? this.keys.map(key => key.id === summary.id ? summary : key)
: [...this.keys, summary]);

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Preserve usability when merging key mutation replies

When an inline upload or rename succeeds, the acknowledgement contains stored key metadata without the transient usable field. Although the server emits a keys_list summary with usable: true before acknowledging, this replacement subsequently overwrites that summary and removes the flag. Since direct saved-connection launching requires usable === true, profiles using the uploaded or renamed key unexpectedly fall back to Quick Connect until keys are reloaded; merge the existing usability value or return a complete key summary.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant