feat: improve saved connection workflows - #69
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d1373164ec
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| this.setKeys(exists | ||
| ? this.keys.map(key => key.id === summary.id ? summary : key) | ||
| : [...this.keys, summary]); |
There was a problem hiding this comment.
Preserve usability when merging key mutation replies
When an inline upload or rename succeeds, the acknowledgement contains stored key metadata without the transient usable field. Although the server emits a keys_list summary with usable: true before acknowledging, this replacement subsequently overwrites that summary and removes the flag. Since direct saved-connection launching requires usable === true, profiles using the uploaded or renamed key unexpectedly fall back to Quick Connect until keys are reloaded; merge the existing usability value or return a complete key summary.
Useful? React with 👍 / 👎.
Summary
Implements the UI scope agreed in Discussion #59.
Security and compatibility
Validation