Skip to content

Fix saved preset dropdown for large libraries#39

Merged
bhack merged 2 commits into
mainfrom
issue-38-large-preset-dropdown
Jun 12, 2026
Merged

Fix saved preset dropdown for large libraries#39
bhack merged 2 commits into
mainfrom
issue-38-large-preset-dropdown

Conversation

@bhack

@bhack bhack commented Jun 6, 2026

Copy link
Copy Markdown
Owner

Summary

  • Replace the custom saved-preset popover with a searchable Gtk.DropDown backed by the preset model.
  • Add explicit placeholder/empty rows so the closed control does not imply a preset is active when no saved preset is loaded.
  • Keep dropdown selection synchronized across refreshes and transient model notifications.
  • Cast fader accessible range values to floats and filter one known external PyGObject GLib warning in pytest output.

Validation

  • .venv/bin/python -m ruff check .
  • .venv/bin/python -m pytest -q (605 passed, 2 skipped)
  • MINI_EQ_RUN_ATSPI=1 dbus-run-session -- .venv/bin/python -m pytest tests/test_mini_eq_atspi_widgets.py::test_real_app_widgets_expose_and_update_accessible_state -q
  • Reproduced the old 35-preset dropdown failure in a nested GTK/AT-SPI run and verified the new dropdown opens with the 35-preset model.
  • Captured and inspected the open long preset dropdown at /tmp/mini-eq-open-dropdown-gtk/popover.png.

@bhack bhack linked an issue Jun 10, 2026 that may be closed by this pull request
2 tasks
@bhack bhack marked this pull request as ready for review June 12, 2026 17:27
@bhack bhack merged commit 408ea30 into main Jun 12, 2026
14 checks passed
@bhack bhack deleted the issue-38-large-preset-dropdown branch June 12, 2026 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Saved preset loading failed when ~30 presets saved

1 participant