Skip to content

Fix 'Example' project compilation and update to Xcode's recommended settings #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
josh- wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Fix 'Example' project compilation and update to Xcode's recommended settings #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
23c4ec5
Update BFPageControl file references in example project
josh- Oct 14, 2017
cb3d3ea
Update to Xcode's recommended Product Bundle Identifier format
josh- Oct 14, 2017
6acd7e5
Fix "Possible misuse of comma operator" warning
josh- Oct 14, 2017
3d427f7
Update compiler settings to recommended Xcode 9 settings
josh- Oct 14, 2017
4914823
Update README screenshot to reflect new macOS system theme
josh- Oct 14, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion BFPageControl/BFPageControl.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ -(id)initWithFrame: (NSRect)frameRect
-(void)updateCurrentPageDisplay
{
if(_matrix)
[_matrix removeFromSuperview], _matrix = nil;
(void)([_matrix removeFromSuperview]), _matrix = nil;

NSUInteger numberOfPages = self.numberOfPages;
if(_hidesForSinglePage && numberOfPages < 2)
Expand Down
55 changes: 46 additions & 9 deletions Example/Example.xcodeproj/project.pbxproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,16 +7,18 @@
objects = {

/* Begin PBXBuildFile section */
039C6E931F91A22300C3B3E1 /* BFPageControl.m in Sources */ = {isa = PBXBuildFile; fileRef = 039C6E911F91A22200C3B3E1 /* BFPageControl.m */; };
602E21A915C239C900DE228D /* Cocoa.framework in Frameworks */ = {isa = PBXBuildFile; fileRef = 602E21A815C239C900DE228D /* Cocoa.framework */; };
602E21B315C239C900DE228D /* InfoPlist.strings in Resources */ = {isa = PBXBuildFile; fileRef = 602E21B115C239C900DE228D /* InfoPlist.strings */; };
602E21B515C239C900DE228D /* main.m in Sources */ = {isa = PBXBuildFile; fileRef = 602E21B415C239C900DE228D /* main.m */; };
602E21B915C239C900DE228D /* Credits.rtf in Resources */ = {isa = PBXBuildFile; fileRef = 602E21B715C239C900DE228D /* Credits.rtf */; };
602E21BC15C239C900DE228D /* AppDelegate.m in Sources */ = {isa = PBXBuildFile; fileRef = 602E21BB15C239C900DE228D /* AppDelegate.m */; };
602E21BF15C239C900DE228D /* MainMenu.xib in Resources */ = {isa = PBXBuildFile; fileRef = 602E21BD15C239C900DE228D /* MainMenu.xib */; };
602E21CB15C23A5400DE228D /* BFPageControl.m in Sources */ = {isa = PBXBuildFile; fileRef = 602E21CA15C23A5400DE228D /* BFPageControl.m */; };
/* End PBXBuildFile section */

/* Begin PBXFileReference section */
039C6E911F91A22200C3B3E1 /* BFPageControl.m */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.objc; name = BFPageControl.m; path = ../../BFPageControl/BFPageControl.m; sourceTree = "<group>"; };
039C6E921F91A22200C3B3E1 /* BFPageControl.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; name = BFPageControl.h; path = ../../BFPageControl/BFPageControl.h; sourceTree = "<group>"; };
602E21A415C239C900DE228D /* Example.app */ = {isa = PBXFileReference; explicitFileType = wrapper.application; includeInIndex = 0; path = Example.app; sourceTree = BUILT_PRODUCTS_DIR; };
602E21A815C239C900DE228D /* Cocoa.framework */ = {isa = PBXFileReference; lastKnownFileType = wrapper.framework; name = Cocoa.framework; path = System/Library/Frameworks/Cocoa.framework; sourceTree = SDKROOT; };
602E21AB15C239C900DE228D /* AppKit.framework */ = {isa = PBXFileReference; lastKnownFileType = wrapper.framework; name = AppKit.framework; path = System/Library/Frameworks/AppKit.framework; sourceTree = SDKROOT; };
Expand All @@ -30,8 +32,6 @@
602E21BA15C239C900DE228D /* AppDelegate.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; path = AppDelegate.h; sourceTree = "<group>"; };
602E21BB15C239C900DE228D /* AppDelegate.m */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.objc; path = AppDelegate.m; sourceTree = "<group>"; };
602E21BE15C239C900DE228D /* en */ = {isa = PBXFileReference; lastKnownFileType = file.xib; name = en; path = en.lproj/MainMenu.xib; sourceTree = "<group>"; };
602E21C915C23A5400DE228D /* BFPageControl.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name = BFPageControl.h; path = ../../BFPageControl.h; sourceTree = "<group>"; };
602E21CA15C23A5400DE228D /* BFPageControl.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; name = BFPageControl.m; path = ../../BFPageControl.m; sourceTree = "<group>"; };
/* End PBXFileReference section */

/* Begin PBXFrameworksBuildPhase section */
Expand Down Expand Up @@ -85,8 +85,8 @@
602E21AE15C239C900DE228D /* Example */ = {
isa = PBXGroup;
children = (
602E21C915C23A5400DE228D /* BFPageControl.h */,
602E21CA15C23A5400DE228D /* BFPageControl.m */,
039C6E921F91A22200C3B3E1 /* BFPageControl.h */,
039C6E911F91A22200C3B3E1 /* BFPageControl.m */,
602E21BA15C239C900DE228D /* AppDelegate.h */,
602E21BB15C239C900DE228D /* AppDelegate.m */,
602E21BD15C239C900DE228D /* MainMenu.xib */,
Expand Down Expand Up @@ -133,7 +133,7 @@
602E219B15C239C900DE228D /* Project object */ = {
isa = PBXProject;
attributes = {
LastUpgradeCheck = 0450;
LastUpgradeCheck = 0900;
ORGANIZATIONNAME = boxedfolder.com;
};
buildConfigurationList = 602E219E15C239C900DE228D /* Build configuration list for PBXProject "Example" */;
Expand Down Expand Up @@ -171,9 +171,9 @@
isa = PBXSourcesBuildPhase;
buildActionMask = 2147483647;
files = (
039C6E931F91A22300C3B3E1 /* BFPageControl.m in Sources */,
602E21B515C239C900DE228D /* main.m in Sources */,
602E21BC15C239C900DE228D /* AppDelegate.m in Sources */,
602E21CB15C23A5400DE228D /* BFPageControl.m in Sources */,
);
runOnlyForDeploymentPostprocessing = 0;
};
Expand Down Expand Up @@ -211,14 +211,30 @@
isa = XCBuildConfiguration;
buildSettings = {
ALWAYS_SEARCH_USER_PATHS = NO;
ARCHS = "$(ARCHS_STANDARD_64_BIT)";
CLANG_CXX_LANGUAGE_STANDARD = "gnu++0x";
CLANG_ENABLE_OBJC_ARC = YES;
CLANG_WARN_BLOCK_CAPTURE_AUTORELEASING = YES;
CLANG_WARN_BOOL_CONVERSION = YES;
CLANG_WARN_COMMA = YES;
CLANG_WARN_CONSTANT_CONVERSION = YES;
CLANG_WARN_EMPTY_BODY = YES;
CLANG_WARN_ENUM_CONVERSION = YES;
CLANG_WARN_INFINITE_RECURSION = YES;
CLANG_WARN_INT_CONVERSION = YES;
CLANG_WARN_NON_LITERAL_NULL_CONVERSION = YES;
CLANG_WARN_OBJC_LITERAL_CONVERSION = YES;
CLANG_WARN_RANGE_LOOP_ANALYSIS = YES;
CLANG_WARN_STRICT_PROTOTYPES = YES;
CLANG_WARN_SUSPICIOUS_MOVE = YES;
CLANG_WARN_UNREACHABLE_CODE = YES;
CLANG_WARN__DUPLICATE_METHOD_MATCH = YES;
COPY_PHASE_STRIP = NO;
ENABLE_STRICT_OBJC_MSGSEND = YES;
ENABLE_TESTABILITY = YES;
GCC_C_LANGUAGE_STANDARD = gnu99;
GCC_DYNAMIC_NO_PIC = NO;
GCC_ENABLE_OBJC_EXCEPTIONS = YES;
GCC_NO_COMMON_BLOCKS = YES;
GCC_OPTIMIZATION_LEVEL = 0;
GCC_PREPROCESSOR_DEFINITIONS = (
"DEBUG=1",
Expand All @@ -227,7 +243,9 @@
GCC_SYMBOLS_PRIVATE_EXTERN = NO;
GCC_WARN_64_TO_32_BIT_CONVERSION = YES;
GCC_WARN_ABOUT_RETURN_TYPE = YES;
GCC_WARN_UNDECLARED_SELECTOR = YES;
GCC_WARN_UNINITIALIZED_AUTOS = YES;
GCC_WARN_UNUSED_FUNCTION = YES;
GCC_WARN_UNUSED_VARIABLE = YES;
MACOSX_DEPLOYMENT_TARGET = 10.8;
ONLY_ACTIVE_ARCH = YES;
Expand All @@ -239,17 +257,34 @@
isa = XCBuildConfiguration;
buildSettings = {
ALWAYS_SEARCH_USER_PATHS = NO;
ARCHS = "$(ARCHS_STANDARD_64_BIT)";
CLANG_CXX_LANGUAGE_STANDARD = "gnu++0x";
CLANG_ENABLE_OBJC_ARC = YES;
CLANG_WARN_BLOCK_CAPTURE_AUTORELEASING = YES;
CLANG_WARN_BOOL_CONVERSION = YES;
CLANG_WARN_COMMA = YES;
CLANG_WARN_CONSTANT_CONVERSION = YES;
CLANG_WARN_EMPTY_BODY = YES;
CLANG_WARN_ENUM_CONVERSION = YES;
CLANG_WARN_INFINITE_RECURSION = YES;
CLANG_WARN_INT_CONVERSION = YES;
CLANG_WARN_NON_LITERAL_NULL_CONVERSION = YES;
CLANG_WARN_OBJC_LITERAL_CONVERSION = YES;
CLANG_WARN_RANGE_LOOP_ANALYSIS = YES;
CLANG_WARN_STRICT_PROTOTYPES = YES;
CLANG_WARN_SUSPICIOUS_MOVE = YES;
CLANG_WARN_UNREACHABLE_CODE = YES;
CLANG_WARN__DUPLICATE_METHOD_MATCH = YES;
COPY_PHASE_STRIP = YES;
DEBUG_INFORMATION_FORMAT = "dwarf-with-dsym";
ENABLE_STRICT_OBJC_MSGSEND = YES;
GCC_C_LANGUAGE_STANDARD = gnu99;
GCC_ENABLE_OBJC_EXCEPTIONS = YES;
GCC_NO_COMMON_BLOCKS = YES;
GCC_WARN_64_TO_32_BIT_CONVERSION = YES;
GCC_WARN_ABOUT_RETURN_TYPE = YES;
GCC_WARN_UNDECLARED_SELECTOR = YES;
GCC_WARN_UNINITIALIZED_AUTOS = YES;
GCC_WARN_UNUSED_FUNCTION = YES;
GCC_WARN_UNUSED_VARIABLE = YES;
MACOSX_DEPLOYMENT_TARGET = 10.8;
SDKROOT = macosx;
Expand All @@ -263,6 +298,7 @@
GCC_PRECOMPILE_PREFIX_HEADER = YES;
GCC_PREFIX_HEADER = "Example/Example-Prefix.pch";
INFOPLIST_FILE = "Example/Example-Info.plist";
PRODUCT_BUNDLE_IDENTIFIER = "com.boxedfolder.${PRODUCT_NAME:rfc1034identifier}";
PRODUCT_NAME = "$(TARGET_NAME)";
WRAPPER_EXTENSION = app;
};
Expand All @@ -275,6 +311,7 @@
GCC_PRECOMPILE_PREFIX_HEADER = YES;
GCC_PREFIX_HEADER = "Example/Example-Prefix.pch";
INFOPLIST_FILE = "Example/Example-Info.plist";
PRODUCT_BUNDLE_IDENTIFIER = "com.boxedfolder.${PRODUCT_NAME:rfc1034identifier}";
PRODUCT_NAME = "$(TARGET_NAME)";
WRAPPER_EXTENSION = app;
};
Expand Down
2 changes: 1 addition & 1 deletion Example/Example/Example-Info.plist
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
<key>CFBundleIconFile</key>
<string></string>
<key>CFBundleIdentifier</key>
<string>com.boxedfolder.${PRODUCT_NAME:rfc1034identifier}</string>
<string>$(PRODUCT_BUNDLE_IDENTIFIER)</string>
<key>CFBundleInfoDictionaryVersion</key>
<string>6.0</string>
<key>CFBundleName</key>
Expand Down
Binary file modified screenshot.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.