Skip to content

fix(js): prevent crashes by validating res.Headers before splitting #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MatrixNeoKozak wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(js): prevent crashes by validating res.Headers before splitting #80

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions gitspoof/gitspoof.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,10 +18,14 @@ function onResponse(req, res) {
}
if (req.Query == 'service=git-upload-pack' && req.Hostname != gitspoof_repo) {
res.Status = 301;
headers = res.Headers.split("\r\n");
for (var i = 0; i < headers.length; i++) {
header_name = headers[i].replace(/:.*/, "");
res.RemoveHeader(header_name);
if (res.Headers) {
var headers = res.Headers.split("\r\n");
for (var i = 0; i < headers.length; i++) {
if (headers[i]) {
var header_name = headers[i].replace(/:.*/, "");
res.RemoveHeader(header_name);
}
}
}
res.SetHeader("Location", "http://" + gitspoof_repo + "/info/refs?service=git-upload-pack");
res.Body = "";
Expand Down
12 changes: 8 additions & 4 deletions web-override/web-override.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,14 @@
// Called before every request is executed, just override the response with
// our own html web page.
function onRequest(req, res) {
headers = res.Headers.split("\r\n");
for (var i = 0; i < headers.length; i++) {
header_name = headers[i].replace(/:.*/, "");
res.RemoveHeader(header_name);
if (res.Headers) {
var headers = res.Headers.split("\r\n");
for (var i = 0; i < headers.length; i++) {
if (headers[i]) {
var header_name = headers[i].replace(/:.*/, "");
res.RemoveHeader(header_name);
}
}
}
res.SetHeader("Connection", "close");
res.Status = 200;
Expand Down