-
-
Notifications
You must be signed in to change notification settings - Fork 1k
Triage: Enable OSD tab for CORE_BUILD firmware #4710
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Tip 📝 Customizable high-level summaries are now available in beta!You can now customize how CodeRabbit generates the high-level summary in your pull requests — including its content, structure, tone, and formatting.
Example instruction:
Note: This feature is currently in beta for Pro-tier users, and pricing will be announced later. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
|
Preview URL: https://pr4710.betaflight-app-preview.pages.dev |
|
i think it is strictly |
|
Core build is for testing driver support - not including features |
|
This was an attempt to troubleshoot the following thread https://discord.com/channels/868013470023548938/1441371803158057042/1441371803158057042 Multiple manufacturers are shipping quads with CORE_BUILD enabled, and the OSD parts seemingly work without issue, the Configurator just won't show the settings for it. I left it as a draft for it to be up to discussion, I can see a point in discouraging the use of CORE_BUILD for production hardware as well. |



To the best of my knowledge and code searching, CORE_BUILD should include OSD drivers, so we should at least show the OSD tab