[RORDEV-1229] Refactor runner CLI flags and add manual workflow dispatch#37
Open
coutoPL wants to merge 14 commits into
Open
[RORDEV-1229] Refactor runner CLI flags and add manual workflow dispatch#37coutoPL wants to merge 14 commits into
coutoPL wants to merge 14 commits into
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
coutoPL
changed the title
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Refactors the test runner CLI to resolve flag naming conflicts and adds manual trigger support for E2E runs via GitHub Actions UI.
Changes
main.sh→runner.sh--modeflag into two distinct flags:--run <e2e|bootstrap>— what to run (previously--mode)--mode <prod|dev>— which image registry to use (previously--dev)--modechange toelk-ror/start.shandeck-ror/start.shworkflow_dispatchinputs to CI so tests can be triggered manually with custom ELK version, env, ROR versions, and modemanual-e2e-testsjob that runs on manual workflow triggers.nvmrc;run-tests.shnow auto-selects the version via nvm or validates itbase.docker-compose.ymlUpdate README examples to reflect the new CLI
Why
The old
--modeflag was ambiguous — it controlled run type (e2e/bootstrap) while a separate--devflag controlled image source. The new flags make intent explicit and consistent across all scripts.Summary by CodeRabbit
New Features
Improvements
Documentation
Chores