1: #392 late days column onto main#509
Merged
cycomachead merged 9 commits intoJul 16, 2026
Merged
Conversation
Add student notes section to instructor view Tested and confirmed this works in development. All tests are passing after rebase
Sync PR #392 (late days column) with current berkeley-cdss/main. Reuses the #394 student-notes conflict resolutions and layers the late-days feature onto main's refactored enrollments view/controller. Kept main's Enrollment#display_role; dropped the duplicate dotenv-rails Gemfile line. Full RSpec suite green.
- Edit Notes button: btn-outline-secondary (California gold #FDB515 on white, 1.78:1) -> btn-outline-primary, which is already tuned for AA contrast in both light and dark themes. - 'No notes yet.' placeholder: .text-muted inside a .bg-light box washed out in dark mode (1.16:1) because bg-light keeps a light surface while text-muted goes near-white. Pin .text-muted to a readable gray within the dark-theme .bg-light override (same pattern already used there for p/li/strong). Verified: full a11y suite (spec/ --tag a11y) 40 examples, 0 failures.
cycomachead
changed the title
cycomachead
changed the title
superconductor-for-github Bot
pushed a commit
that referenced
this pull request
Jul 16, 2026
Re-sync with main after #509 (late days column) merged. Clean auto-merge; schema retains good_jobs tables + notes column. Full RSpec (594) + a11y (40) green; RuboCop clean.
superconductor-for-github Bot
pushed a commit
that referenced
this pull request
Jul 16, 2026
Re-sync with main after #509 (late days column) merged. Clean auto-merge; schema retains good_jobs tables + notes column. Full RSpec (594) + a11y (40) green; RuboCop clean.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preview-only sync of #392 (late days column) onto current
main.Preserves PR #392 history (which is stacked on #394) and merges current
main, reusing the #394 student-notes resolutions and layering the late-days feature onto main's refactored enrollments view/controller.Notable resolutions:
Enrollment#display_role(main) rather than SP26 #4: (47) Add late days column for extensions #392'srole.downcase.capitalizeregression.dotenv-railsGemfile entry; keptgood_jobgem (inert here, configured in SP26 #5: (89) Make sync enrollments and sync assignments async with Good_job gem and Added good_job gem dashboard permission control #390).@course.user_to_courses→@course.enrollments.Net vs
main: student-notes + late-days only (21 files). Full RSpec suite green (573 examples); RuboCop clean.Original PR: #392 · Stacked on #508