feat(web): move every lab's controls bar above the canvas - #21
Merged
Merged
Conversation
The playback/controls bar now sits at the top of the page in every lab, on desktop and in the mobile stack, and precedes the canvas in DOM order so tab order matches the visual order. Border moves from top to bottom of the bar to keep the separator between bar and canvas.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves the playback/controls bar from below the canvas to the top of the page in every lab (Sierpinski, Fourier, Sorting), on desktop and in the mobile stack.
.canvas-wrapVerified in the browser on all three labs at desktop and 375px widths.