Repository navigation
Conversation
prototype/demo.sh was committed with mode 100644, so the `./demo.sh` that the README shows failed with "Permission denied". It is now executable. It moves to examples/archery-compare/run.sh, next to the other examples' run.sh. The directory takes over the old examples/demo, the demo's project root with its benchx.conf.json and its git-ignored store, so the script finds its project file and the sibling examples/demo-suite relative to itself and can be started from any directory. The README, the archery-local README and prototype-design.md name the new paths. The project name `demo` in the store is unchanged. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Add a step after the archery-local example, with the same toolchain needs (cmake, a C++ compiler, network for Google Benchmark), so it is skipped on Windows. ROUNDS=2 keeps the job to about a minute and a half; it lowers the number of samples, not what the script exercises. The script is run directly, as the README shows it, so a lost executable bit fails here too. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
ev-br
changed the title
demo.sh on CI)demo.sh) on CI
Collaborator
Author
|
The CI run is ~6-9 minutes depending on the architecture, and mixes up unit tests and end-to-end tests/examples. I'll look into splitting the former from latter and consolidating e2e examples together with those from |
ev-br
marked this pull request as draft
November 1, 2026 20:39
Collaborator
Author
|
superseded by #98 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
demo.shscript was meant to demonstrate abenchxworkflow using the gperf harness. Make it runnable, add it to CI so that it stays runnable, and rename toarchery-compareto follow the existingarchery-localexample.The plan for all examples is to collect them together in the
benchx_examplesrepository, so this PR is a preparation to make sure it is actually runnable.One question is whether calling
archery-localandarchery-compareexample is correct. Neither example usesarcheryitself. Am happy to immediately rename either or both to any name @rok and @raulcd find suitable.