You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently the pre-commit hooks shows various lint errors. I ran the pre-commit hook to fix them. This commit does not resolve the markdownlint errors though so those have to be fixed separately.
I'm unsure if we want to make these edits or just disable markdownlint etc, but worthwhile to start a conversation about the existing lint errors.
make these edits or just disable markdownlint etc, but worthwhile to start a conversation about the existing lint errors.
I'm inclined to disable the lint as I don't think it's telling us anything useful here. Also all the stuff in docs like the beman standard is maintained in the Beman repo so we'd have to go back over there and make the updates there. I'm certainly not opposed to the cleanup, but I feel like we have better uses of our time when not one of these changes will materially change the site...
Totally agreed. I'll upload a simpler commit which just disables these checks to make the job pass. Will leave CI open in some .py scripts but that's all.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the pre-commit hooks shows various lint errors. I ran the pre-commit hook to fix them. This commit does not resolve the markdownlint errors though so those have to be fixed separately.
I'm unsure if we want to make these edits or just disable markdownlint etc, but worthwhile to start a conversation about the existing lint errors.