Skip to content

Fix various lint errors via pre-commit hook#174

Open
sakshamsharma wants to merge 1 commit into
bemanproject:mainfrom
sakshamsharma:fix-lint
Open

Fix various lint errors via pre-commit hook#174
sakshamsharma wants to merge 1 commit into
bemanproject:mainfrom
sakshamsharma:fix-lint

Conversation

@sakshamsharma
Copy link
Copy Markdown
Contributor

@sakshamsharma sakshamsharma commented May 31, 2026

Currently the pre-commit hooks shows various lint errors. I ran the pre-commit hook to fix them. This commit does not resolve the markdownlint errors though so those have to be fixed separately.
I'm unsure if we want to make these edits or just disable markdownlint etc, but worthwhile to start a conversation about the existing lint errors.

@netlify
Copy link
Copy Markdown

netlify Bot commented May 31, 2026

Deploy Preview for bemanproject ready!

Name Link
🔨 Latest commit 187bd79
🔍 Latest deploy log https://app.netlify.com/projects/bemanproject/deploys/6a1ca11b96f0430008657e5f
😎 Deploy Preview https://deploy-preview-174--bemanproject.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@JeffGarland
Copy link
Copy Markdown
Member

make these edits or just disable markdownlint etc, but worthwhile to start a conversation about the existing lint errors.

I'm inclined to disable the lint as I don't think it's telling us anything useful here. Also all the stuff in docs like the beman standard is maintained in the Beman repo so we'd have to go back over there and make the updates there. I'm certainly not opposed to the cleanup, but I feel like we have better uses of our time when not one of these changes will materially change the site...

@sakshamsharma
Copy link
Copy Markdown
Contributor Author

Totally agreed. I'll upload a simpler commit which just disables these checks to make the job pass. Will leave CI open in some .py scripts but that's all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants