test(convert): cover never_convert_lossy_files in playlist entry tests#6812
Open
Kidus5168 wants to merge 4 commits into
Open
test(convert): cover never_convert_lossy_files in playlist entry tests#6812Kidus5168 wants to merge 4 commits into
Kidus5168 wants to merge 4 commits into
Conversation
Add a parametrize case to test_playlist_entry verifying that when never_convert_lossy_files=True prevents transcoding of a lossy file, the generated playlist entry keeps the original file extension. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
Thank you for the PR! The changelog has not been updated, so here is a friendly reminder to check if you need to add an entry. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #6812 +/- ##
==========================================
+ Coverage 74.78% 74.80% +0.01%
==========================================
Files 163 163
Lines 20966 20966
Branches 3302 3302
==========================================
+ Hits 15680 15684 +4
+ Misses 4529 4527 -2
+ Partials 757 755 -2 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add a
never_convert_lossy_filesparametrize case totest_playlist_entryin the convert plugin tests.This verifies that when
never_convert_lossy_files=Trueprevents transcoding of a lossy file, the generated playlist entry correctly keeps the original file extension rather than replacing it with the target format extension.Test plan
poetry run pytest test/plugins/test_convert.py -k playlist -v— all 7 tests pass