Skip to content

test(convert): cover never_convert_lossy_files in playlist entry tests#6812

Open
Kidus5168 wants to merge 4 commits into
beetbox:masterfrom
Kidus5168:fix-playlist-extension
Open

test(convert): cover never_convert_lossy_files in playlist entry tests#6812
Kidus5168 wants to merge 4 commits into
beetbox:masterfrom
Kidus5168:fix-playlist-extension

Conversation

@Kidus5168

Copy link
Copy Markdown

Summary

Add a never_convert_lossy_files parametrize case to test_playlist_entry in the convert plugin tests.

This verifies that when never_convert_lossy_files=True prevents transcoding of a lossy file, the generated playlist entry correctly keeps the original file extension rather than replacing it with the target format extension.

Test plan

  • poetry run pytest test/plugins/test_convert.py -k playlist -v — all 7 tests pass

Add a parametrize case to test_playlist_entry verifying that when
never_convert_lossy_files=True prevents transcoding of a lossy file,
the generated playlist entry keeps the original file extension.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@Kidus5168 Kidus5168 requested a review from a team as a code owner July 1, 2026 04:17
@github-actions

github-actions Bot commented Jul 1, 2026

Copy link
Copy Markdown

Thank you for the PR! The changelog has not been updated, so here is a friendly reminder to check if you need to add an entry.

@codecov

codecov Bot commented Jul 1, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.80%. Comparing base (c90f42d) to head (c80612d).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6812      +/-   ##
==========================================
+ Coverage   74.78%   74.80%   +0.01%     
==========================================
  Files         163      163              
  Lines       20966    20966              
  Branches     3302     3302              
==========================================
+ Hits        15680    15684       +4     
+ Misses       4529     4527       -2     
+ Partials      757      755       -2     

see 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant