Detach stdin when running badfiles checker commands#6797
Open
augboz wants to merge 2 commits into
Open
Conversation
The `badfiles` checker commands (mp3val, flac, custom) are non-interactive, but were launched with the parent process's stdin still attached to the controlling terminal. A checker could leave the TTY in a modified state (e.g. with input echo disabled), so after `beet bad` the terminal stopped echoing typed input until `reset` or `stty sane` was run. Pass `stdin=DEVNULL` to `check_output` so the checkers cannot read from or modify the terminal. Adds a regression test asserting `run_command` detaches stdin, plus a changelog entry. Closes beetbox#6750
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #6797 +/- ##
==========================================
+ Coverage 74.85% 74.87% +0.02%
==========================================
Files 163 163
Lines 20947 20947
Branches 3299 3299
==========================================
+ Hits 15680 15685 +5
+ Misses 4510 4504 -6
- Partials 757 758 +1
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #6750.
The
badfileschecker commands (mp3val,flac, custom) are non-interactive, butrun_commandlaunched them with the parent's stdin still attached to the controlling terminal. A checker can leave the TTY in a modified state (e.g. echo disabled), so afterbeet badthe terminal stops echoing typed input untilreset/stty sane.Fix: pass
stdin=DEVNULLtocheck_outputso checkers can't read from or modify the terminal.Note on verification: the symptom is terminal-state-specific and I couldn't reproduce it on my (Windows) machine, but the root cause is clear from the code path. I've added a regression test asserting
run_commandcallscheck_outputwithstdin=DEVNULL, and a changelog entry.