Introduce logging modes#6773
Draft
semohr wants to merge 6 commits into
Draft
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## remove_logging_import_sideeffect #6773 +/- ##
=================================================================
Coverage 74.84% 74.84%
=================================================================
Files 163 163
Lines 20958 20958
Branches 3300 3300
=================================================================
Hits 15687 15687
Misses 4513 4513
Partials 758 758 🚀 New features to boost your workflow:
|
will propagate and log properly.
semohr
force-pushed
the
remove_logging_import_sideeffect
branch
from
3195bfd to
d20b418
Compare
and decision making at the moment.
Contributor
Author
|
@JOJ0 Would you mind having a look 🙃 |
semohr
force-pushed
the
remove_logging_import_sideeffect
branch
2 times, most recently
from
f6062a8 to
a5d17fc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We’ve made solid progress over the past months on the logging enhancements proposed in #6553. It’s now a good time to align on a clear direction for how logging modes should work going forward.
I’ve put together an initial draft of the updated logging specification in the documentation. @beetbox/maintainers Please take a look and share your ideas/feedback/questions.
Once we’re aligned on the approach, I’ll proceed with the implementation.
This is related to the multi-step efforts to improve logging in beets #6553