Skip to content

lyrics: add --no-keep-synced CLI option#6769

Open
snejus wants to merge 1 commit into
masterfrom
lyrics-add-no-keep-synced-cli-opt
Open

lyrics: add --no-keep-synced CLI option#6769
snejus wants to merge 1 commit into
masterfrom
lyrics-add-no-keep-synced-cli-opt

Conversation

@snejus

@snejus snejus commented Jun 24, 2026

Copy link
Copy Markdown
Member
  • This change adds a small CLI override to beetsplug/lyrics.py: --no-keep-synced. It is the inverse of --keep-synced, and lets one manual lyrics run ignore the configured keep_synced: yes.

Copilot AI review requested due to automatic review settings June 24, 2026 03:14
@snejus snejus requested a review from a team as a code owner June 24, 2026 03:14
@github-actions github-actions Bot added the lyrics lyrics plugin label Jun 24, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

grug see PR add new CLI flag for lyrics plugin. goal: one manual beet lyrics run can ignore config keep_synced: yes and not skip synced-lyrics items.

Changes:

  • add --no-keep-synced option to lyrics command, mapping to keep_synced=False
  • add pytest for config-vs-CLI precedence for keep_synced
  • update lyrics plugin docs + changelog entry

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
beetsplug/lyrics.py add --no-keep-synced CLI option (inverse of --keep-synced)
test/plugins/test_lyrics.py add test for CLI overriding keep_synced config
docs/plugins/lyrics.rst document new --no-keep-synced usage
docs/changelog.rst add unreleased changelog note for new option

Comment thread beetsplug/lyrics.py
@codecov

codecov Bot commented Jun 24, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.03%. Comparing base (37e2a8b) to head (eeb1960).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6769      +/-   ##
==========================================
+ Coverage   74.85%   75.03%   +0.18%     
==========================================
  Files         163      163              
  Lines       20947    20948       +1     
  Branches     3299     3299              
==========================================
+ Hits        15680    15719      +39     
+ Misses       4510     4469      -41     
- Partials      757      760       +3     
Files with missing lines Coverage Δ
beetsplug/lyrics.py 90.00% <100.00%> (+7.72%) ⬆️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@snejus snejus force-pushed the lyrics-add-no-keep-synced-cli-opt branch 2 times, most recently from 0b6bdcf to 35aa3f9 Compare June 28, 2026 00:22
- Allow manual lyrics fetches to override keep_synced configuration for a single
  run.
@snejus snejus force-pushed the lyrics-add-no-keep-synced-cli-opt branch from 35aa3f9 to eeb1960 Compare June 28, 2026 00:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lyrics lyrics plugin

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants