Skip to content

test: release the first connection before asserting the second reuses it #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AlexeyShalaev merged 1 commit into from
Sep 6, 2026
Merged

test: release the first connection before asserting the second reuses it #23

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions tests/integration/adapters/test_aiohttp.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -245,8 +245,13 @@ async def test__failure_paths__never_leak_inflight(
async def test__conn_metrics__annotate_the_call_span(origin: OriginServer) -> None:
tracer = RecordingTracer()
client = await build(base_config(origin), AdapterDeps(tracer=tracer))
await client.get("/echo")
await client.get("/echo")
# Read each body before the next call: aiohttp returns a connection to the
# pool on release, so an unread response leaves the second call racing the
# first one's cleanup for it -- which is how this test used to flake.
first = await client.get("/echo")
await first.read()
second = await client.get("/echo")
await second.read()
await client.close()
fresh, pooled = (span.attributes for span in tracer.spans)
assert fresh["http.connection.connect_duration"] >= 0.0 # TraceConfig timed the handshake
Expand Down