fix: retry gating, native override reporting and connection metrics - #21
Merged
Conversation
The work landed in #20. Its squash subject lost the Conventional Commit prefix -- my mistake on the merge, not the author's -- so release-please skipped the merge and these fixes would never have reached a release. This commit carries the record. It changes no code: #20 is already on master. * retry.methods could not narrow at all. The gate was a disjunction of two permissions, so neither half could refuse: a DELETE stayed retryable after an operator removed it from the list, and an explicit idempotent=False was ignored. It now reads a flag that contradicts the method's RFC default as the call site deciding, and one that merely restates it as deferring to retry.methods. * ConfigApplicationReport.native_overrides was always empty, though two guides promised it listed the accepted passthrough per slot. Every adapter fills it. * conn_metrics had no consumer, so Attempt.conn was always None and aiohttp's DNS, connect, pool-wait and reuse timings reached nothing. Both engines fill it and the emitter puts the timings on the call span. * redact_headers is exported from the package root, beside the DEFAULT_SENSITIVE_HEADERS constant it is the only use for.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No code changes. This is one empty commit whose message restores a record the merge of #20 lost.
I squash-merged #20 using its pull request title as the commit subject, and that title was written as prose — "Fix the defects the agents page turned up" — not as a Conventional Commit. release-please parses subjects, found nothing releasable since
clientwright-v0.2.0, and opened no release pull request. The fixes are onmasterand would have sat there indefinitely. My mistake on the merge, not the author's.The commit here carries the same summary with a
fix:subject, so the pending release is computed and the changelog says what changed:retry.methodscould not narrow at all — the gate was a disjunction of two permissions, so aDELETEstayed retryable after an operator removed it from the list, and an explicitidempotent=Falsewas ignored.ConfigApplicationReport.native_overrideswas always empty while two guides promised it listed the accepted passthrough per slot.conn_metricshad no consumer, soAttempt.connwas alwaysNoneand aiohttp's connection timings surfaced nowhere.redact_headersis now a root export.The diff is empty by design. Reviewing it means reading #20.