[NEW][hermesagent][1.3.2]Hermes Agent#2299
Conversation
Package Hermes Agent for Olares Market as a cloneable multi-entrance app with a CLI workspace, Control UI, terminal helper deployment, and proxy ingress, following the repository's existing assistant-app chart conventions. Constraint: Market apps in this repo must live under a single app directory with OlaresManifest, Chart, values, templates, owners, and i18n metadata Constraint: Hermes currently relies on an external GHCR image published from progress44/hermes-agent Rejected: Submit the raw backend repo chart unchanged | missing the i18n, owners, and packaging conventions used in beclab/apps Rejected: Model this as a shared app | Hermes is intended as a cloneable ordinary app, not a cluster-scoped shared service Confidence: medium Scope-risk: moderate Reversibility: clean Directive: Keep the Market package metadata aligned with the Hermes Olares chart version and image tag when updating this app in the future Tested: helm lint/template against /Users/asinanaj/Projects/Code/beclab-apps/hermesagent using the local Helm binary Not-tested: GitBot checks in beclab/apps, Olares Market review, or install from the upstream market index
|
After the modification is completed, please click ready for review to submit the PR |
|
Resolves issue #2227 |
|
Chart invalid. Error message: [templates/deployment.yaml line 48: image field must not contain template placeholders |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f62c25ea3f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| - name: init-hermes-data | ||
| image: beclab/aboveos-busybox:1.37.0 | ||
| securityContext: | ||
| runAsUser: 0 |
There was a problem hiding this comment.
The pod-level securityContext sets runAsNonRoot: true, and this init container then sets runAsUser: 0; that combination is invalid for Kubernetes and causes the init container to be rejected at startup, so the Deployment never finishes initialization and the app cannot come up. Please either override this init container with runAsNonRoot: false or avoid enforcing non-root at pod scope when a root init step is required.
Useful? React with 👍 / 👎.
Update the Hermes Market package so container image fields are literal values accepted by beclab/apps validation, and move first-boot config seeding into a single init container instead of racing across runtime role containers. Constraint: beclab/apps rejects template placeholders in image fields Constraint: the Hermes Market package should expose Control UI even when the gateway sidecar is not yet configured Rejected: Leave templated image fields in deployment | upstream market validation blocks the PR entirely Rejected: Keep bootstrap in the shared runtime entrypoint | first-boot state is nondeterministic with multiple role containers Confidence: high Scope-risk: moderate Reversibility: clean Directive: Keep the market package synced from the Hermes source chart after any future Olares runtime changes Tested: helm lint/template against /Users/asinanaj/Projects/Code/beclab-apps/hermesagent using the local Helm binary Not-tested: Upstream GitBot checks or a real install from the market PR branch
|
Chart invalid. Error message: [sum of all containers resources limits cpu should less than OlaresManifest.yaml spec.limitedCpu (sumLimits=6.200000, limitedCpu=4.000000) |
|
Hi, @progress44 We are actually working on an official port as well and are currently testing it. We think it would be beneficial to combine our efforts to ensure the best quality for the project. If you're open to it, we could either contribute fixes directly to this PR, or we can wait until our version is ready and work together on a final version. We value your input and would love to collaborate. What do you think? |
|
Hey, whichever is faster, if this is a good base to start, you can go ahead and contribute here. If you are in a good place with your progress, we can discard my pr :D |
|
After the modification is completed, please click ready for review to submit the PR |
|
After the modification is completed, please click ready for review to submit the PR |
TShentu
changed the title
|
After the modification is completed, please click ready for review to submit the PR |
3 participants
PR Title
[NEW][hermesagent][1.1.0]Hermes Agent
App Title
Hermes Agent
Description
Add Hermes Agent as a cloneable Olares Market app with two entrances:
This package follows the multi-entrance assistant shape used by OpenClaw, with a persistent workspace container, dashboard sidecar, gateway sidecar, terminal helper deployment, and proxy ingress.
Statement
OlaresManifest.yaml