Repository navigation
ci: resolve merged PR number with bcgov/actions/image-tracker - #680
Merged
Merged
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
The action’s inputs and permissions match its requirements, and the downstream deployment output remains compatible.
No open issues 🎉
What changed in this PR
Replaces the retiring PR-number lookup action while preserving the image tags used for TEST and PROD deployments.
Changes:
- Uses image-tracker pinned to v0.9.0 to resolve the PR number and verify all three images.
- Adds checkout and package-read permission while retaining the existing
proutput.
| File | Description |
|---|---|
.github/workflows/merge.yml |
Migrates PR-number resolution to image-tracker with its required setup. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
merge.ymlgets the merged PR number from the retiringbcgov/action-get-pr, and that number is the image tag for the TEST and PROD deploys.Following the #202 migration guidance, the
initjob now usesbcgov/actions/image-tracker@79aefe3(v0.9.0) and keeps itsproutput, soneeds.init.outputs.prand every TEST and PROD tag stay the same. To work, image-tracker needs a checkout andpackages: read. Nothing else changes, and no versions change.Tag equivalence
How each one finds the number for a push to
main:/commits/{sha}/pulls).(#N)from the squash subject (or the same API), then checks that GHCR has tagNforapi,frontendanddatabase. Itsproutput is thatN.So the value matches, and image-tracker also fails before deploying if any of the three images is missing.
I ran image-tracker v0.9.0 locally against the last 12 commits on
mainand compared it with the get-pr API answer. All 12 matched:workflow_dispatchruns onmainresolveHEADthe same way.Thanks for the PR!
Deployments, as required, will be available below:
Please create PRs in draft mode. Mark as ready to enable:
After merge, new images are deployed in: