Repository navigation
fix(api): run the API on Node 24, matching its build - #666
Merged
Merged
Conversation
The runtime stage used the Node 22 distroless image while dependencies were installed and tested on Node 24. Refs #597
There was a problem hiding this comment.
🟢 Approval recommended
The focused image update correctly resolves the build/runtime Node.js version mismatch.
0 open findings
What changed in this PR
Aligns the API runtime with its Node 24 build and CI environment.
Changes:
- Updates the distroless runtime image from Node 22 to Node 24 on Debian 12.
| File | Description |
|---|---|
api/Dockerfile |
Uses the Node 24 distroless runtime image. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The API image installs its dependencies with Node 24 but runs them on the Node 22 distroless image, so the runtime is a different major version from the one CI tests on.
Refs #597
Changes
gcr.io/distroless/nodejs24-debian12:nonroot, the image quickstart-openshift's backend uses. It now matches thenode:24build stage and the Node 24 that theAPI Testsjob runs on.Thanks for the PR!
Deployments, as required, will be available below:
Please create PRs in draft mode. Mark as ready to enable:
After merge, new images are deployed in: