Repository navigation
fix(ci): let the ministry list job open its pull request and notify on failure - #661
Merged
Merged
Conversation
…n failure The job pushed to a fixed chore/ministry-name-schema branch, so once that branch existed every later run failed at the push and no pull request was opened. Each run now uses its own branch, skips when a ministry name pull request is already open, commits as github-actions[bot] and assigns DerekRoberts. A notify job opens or updates an issue through workflow-notifier when any scheduled job fails.
There was a problem hiding this comment.
🟡 Changes recommended
Re-runs can reuse an existing branch, and generated PRs cannot trigger required checks.
2 open findings
What changed in this PR
Improves scheduled ministry-schema updates and adds failure notifications.
Changes:
- Creates uniquely named branches and ministry update PRs.
- Prevents duplicate open PRs.
- Notifies CODEOWNERS when scheduled jobs fail.
| File | Description |
|---|---|
.github/workflows/scheduled.yml |
Updates schema PR automation and adds failure notification. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
A re-run keeps the run id, so a retry after a failed pull request step would hit the same push rejection.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The scheduled
validate-ministry-listjob has failed every day. It finds the ministry name change, then pushes to a fixedchore/ministry-name-schemabranch. That branch already exists from 2024, so the push is rejected and no pull request is ever opened. Scheduled failures also notify no one.Changes in
scheduled.ymlchore/ministry-names-<run id>-<attempt>, so a leftover branch can't block it.user.nameanduser.emailtogithub-actions[bot].DerekRobertsreplaces the hardcodedmishraomp. CODEOWNERS still requests reviews from both owners.fix(schema): update ministry names from gov.bc.ca.notifyjob runsbcgov/actions/workflow-notifierv0.8.0 when any scheduled job fails. For a scheduled run it opens an issue assigned to the CODEOWNERS, or comments on the open one.Not verified by CI
PR checks don't run this workflow. A manual run would also run the crawler and soft-delete jobs against prod, so the new pull-request step has not run yet.
Two more things to know:
gh pr createneeds "Allow GitHub Actions to create and approve pull requests". The repo's workflow permission API reportscan_approve_pull_request_reviews: true, so this should work.Thanks for the PR!
Deployments, as required, will be available below:
Please create PRs in draft mode. Mark as ready to enable:
After merge, new images are deployed in: