Repository navigation
fix(schema): match ministry names to the current gov.bc.ca list - #659
Merged
Merged
Conversation
Eight ministries were renamed, merged or added since the schema was last updated. The enum now equals the list on the ministries page, in the same order, so the scheduled validate-ministry-list job sees no change.
There was a problem hiding this comment.
🟢 Approval recommended
The schema remains valid and the ministry list exactly matches the official names and ordering.
0 open findings
What changed in this PR
Updates the schema’s ministry enum to match the current official B.C. government list.
Changes:
- Renames outdated ministries.
- Adds newly established ministries.
- Removes obsolete entries and preserves official ordering.
| File | Description |
|---|---|
schema/bcgovpubcode.json |
Updates the ministry enum to the current 23 ministries. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ministry list in
schema/bcgovpubcode.jsonno longer matches the ministries page. Since the form loads its schema frommain, it offers ministries that no longer exist and leaves out the new ones.Changes
The ministry enum is updated to equal the page exactly, in the same order:
Why the list went stale
The scheduled
validate-ministry-listjob compares the schema with this page. It has been finding the mismatch, but its push fails because a stalechore/ministry-name-schemabranch from 2024 already exists, so it never opened a PR. After this merges, the job finds no change.Existing
bcgovpubcode.ymlfiles that still use an old name will fail form validation the next time they're edited, until a current ministry is picked.Thanks for the PR!
Deployments, as required, will be available below:
Please create PRs in draft mode. Mark as ready to enable:
After merge, new images are deployed in: