AB#34140 - Scoped primary address exclusivity by address type - #2867
Draft
hasanpour wants to merge 2 commits into
Draft
AB#34140 - Scoped primary address exclusivity by address type#2867hasanpour wants to merge 2 commits into
hasanpour wants to merge 2 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Scopes primary-address exclusivity by address type and centralizes enforcement in the domain layer.
Changes:
- Adds shared address-type mapping and primary-flag helpers.
- Introduces a domain service for demotion and re-election.
- Updates portal handlers, profile inference, and tests.
Reviewed changes
Copilot reviewed 15 out of 15 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
AddressTypeMapperTests.cs |
Tests portal address-type mapping. |
AddressSetPrimaryHandlerTests.cs |
Tests type-scoped primary selection. |
AddressEditHandlerTests.cs |
Tests primary handling during edits. |
AddressDeleteHandlerTests.cs |
Tests primary re-election after deletion. |
AddressCreateHandlerTests.cs |
Tests scoped demotion during creation. |
AddressInfoDataProviderTests.cs |
Tests per-type primary inference. |
IApplicantAddressManager.cs |
Defines primary-address operations. |
ApplicantAddressManager.cs |
Implements demotion and election logic. |
ApplicantAddress.cs |
Adds primary-flag helpers. |
AddressTypeMapper.cs |
Centralizes portal type translation. |
AddressSetPrimaryHandler.cs |
Delegates scoped demotion. |
AddressEditHandler.cs |
Handles type changes and primary reassignment. |
AddressDeleteHandler.cs |
Re-elects a primary after deletion. |
AddressCreateHandler.cs |
Applies scoped demotion before creation. |
AddressInfoDataProvider.cs |
Infers primaries by address type. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
🧪 Unit Test Results (Parallel Execution)📊 Summary
📄 HTML Reports
|
|
🧪 Unit Test Results (Parallel Execution)📊 Summary
📄 HTML Reports
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.