Skip to content

Dev #2857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JamesPasta merged 2 commits into from
Aug 20, 2026
Merged

Dev #2857

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ea842c1
feature/AB#34135-InsantMessaging-bundling issue
JamesPasta Aug 20, 2026
444dc5a
Merge pull request #2856 from bcgov/feature/AB#34135-InstantMessaging
JamesPasta Aug 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion ...ules/Unity.Theme.UX2/src/Unity.Theme.UX2/Bundling/UnityThemeUX2GlobalScriptContributor.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@ public override void ConfigureBundle(BundleConfigurationContext context)
context.Files.AddIfNotContains("/libs/datatables.net-colreorder-bs5/js/colReorder.bootstrap5.min.js");

context.Files.AddIfNotContains("/libs/echarts/echarts.min.js");
context.Files.AddIfNotContains("/libs/tributejs/dist/tribute.min.js");

context.Files.AddIfNotContains("/libs/tinymce/tinymce.min.js");
context.Files.AddIfNotContains("/libs/tinymce/themes/silver/theme.min.js");
Expand Down
6 changes: 4 additions & 2 deletions ...rantManager/modules/Unity.Theme.UX2/src/Unity.Theme.UX2/Themes/UX2/Layouts/Account.cshtml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,9 +99,11 @@
</abp-row>
</div>

@* Loaded outside the bundle: re-minifying this already-minified library alongside the rest of
UX2.Global corrupts its automatic-reconnect closures into unbounded mutual recursion. *@
@* Loaded outside the bundle: re-minifying these already-minified libraries alongside the rest
of UX2.Global risks corrupting their internal closures (observed for SignalR's
automatic-reconnect logic; tribute.js's active regex scanning is suspected similarly). *@
<script src="~/libs/signalr/browser/signalr.min.js"></script>
<script src="~/libs/tributejs/dist/tribute.min.js"></script>
<abp-script-bundle name="@UnityThemeUX2Bundles.Scripts.Global" />

<script src="~/Abp/ApplicationLocalizationScript?cultureName=@CultureInfo.CurrentUICulture.Name"></script>
Expand Down
6 changes: 4 additions & 2 deletions ...Manager/modules/Unity.Theme.UX2/src/Unity.Theme.UX2/Themes/UX2/Layouts/Application.cshtml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,9 +109,11 @@
@await Component.InvokeLayoutHookAsync(LayoutHooks.PageContent.Last, StandardLayouts.Application)
</div>

@* Loaded outside the bundle: re-minifying this already-minified library alongside the rest of
UX2.Global corrupts its automatic-reconnect closures into unbounded mutual recursion. *@
@* Loaded outside the bundle: re-minifying these already-minified libraries alongside the rest
of UX2.Global risks corrupting their internal closures (observed for SignalR's
automatic-reconnect logic; tribute.js's active regex scanning is suspected similarly). *@
<script src="~/libs/signalr/browser/signalr.min.js"></script>
<script src="~/libs/tributejs/dist/tribute.min.js"></script>
<abp-script-bundle name="@UnityThemeUX2Bundles.Scripts.Global" />

<script src="~/Abp/ApplicationLocalizationScript?cultureName=@CultureInfo.CurrentUICulture.Name"></script>
Expand Down
6 changes: 4 additions & 2 deletions ....GrantManager/modules/Unity.Theme.UX2/src/Unity.Theme.UX2/Themes/UX2/Layouts/Empty.cshtml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,9 +66,11 @@

<script src="~/js/jquery-polyfills.js"></script>

@* Loaded outside the bundle: re-minifying this already-minified library alongside the rest of
UX2.Global corrupts its automatic-reconnect closures into unbounded mutual recursion. *@
@* Loaded outside the bundle: re-minifying these already-minified libraries alongside the rest
of UX2.Global risks corrupting their internal closures (observed for SignalR's
automatic-reconnect logic; tribute.js's active regex scanning is suspected similarly). *@
<script src="~/libs/signalr/browser/signalr.min.js"></script>
<script src="~/libs/tributejs/dist/tribute.min.js"></script>
<abp-script-bundle name="@UnityThemeUX2Bundles.Scripts.Global" />

<script src="~/Abp/ApplicationLocalizationScript?cultureName=@CultureInfo.CurrentUICulture.Name"></script>
Expand Down
Loading